fossapps / pushy Goto Github PK
View Code? Open in Web Editor NEWStrongly Typed SDK for pushy.me platform
License: MIT License
Strongly Typed SDK for pushy.me platform
License: MIT License
https://github.com/cyberhck/pushy/blob/5fdbe22977a0474a4894b3e1f9261b1a2fd6c9d4/.travis.yml#L5
we're using string for version number
look into: travis-ci/gimme#132 & travis-ci/gimme#130
wait for pull to merge and 132 to close
https://github.com/cyberhck/pushy/blob/master/pushy.go#L51
I saw in other places you use fmt.Sprintf
, can be used in all places to have code consistent.
Also, here p.APIEndpoint
can be moved to Sprintf args and replaced by %s
.
https://github.com/cyberhck/pushy/blob/master/pushy.go#L69
I'd like some example tests, they'll make sure our documentation is awesome
https://github.com/cyberhck/pushy/blob/master/pushy.go#L123
I think in get/post/del functions it's not necessary to set nil
in case of error, as by default all these vars are nil
.
It will reduce code size.
https://github.com/cyberhck/pushy/blob/master/pushy.go#L157
json.NewDecoder(b).Decode(posRes)
has error
as return value. Your function also returns error. I think it's better not to skip errors and do:
return json.NewDecoder(b).Decode(posRes)
Initialize code quality tools
https://github.com/cyberhck/pushy/blob/master/.travis.yml
Now top is 1.10 (or will be soon).
You should add 1.9 and 1.10
When using pushy, it'd be quite nice if one could easily mock pushy responses.
I wanted to move this to a new organization where it'll live.
Since it's moved, we'll need to update readme, setup travis etc.
While doing that I'll try to setup linting, vet, etc (it'll be even more awesome if I could use github checks api)
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.