fortytw2 / dockertest Goto Github PK

this will allow us to kill all containers tagged dockertest on boot without much worry

Right now it just hangs forever?

I have a project named Gorsk that uses dockertest for database tests.

It ran all fine until 2020-01-06. I tested it today, the tests won't run and it waits endlessly.

I assume something changed on Docker, but can't tell precisely what.

When using docker on OSX (installed via homebrew), the docker run command makes the container available at docker-machine ip NAME - but not on localhost.

docker-for-mac is already prepared to make the container available in localhost, but in order to support docker-machine, dockertest should allow custom hosts.

#2 is using the DOCKER_MACHINE_NAME env variable to lookup for the current docker-machine host, otherwise it will fallback to localhost.

Hello,

looking at docker-machine env, there's also DOCKER_HOST available;

set -x DOCKER_HOST tcp://192.168.99.102:2376;

It should be trivial to use this instead, removing the dependency on docker-machine. Alternatively, it might be (somehow) useful to set the hostname by hand.

Edit: At least partially it can be done with a -H option for docker run and ignoring the hostname part from the hostname:port address passed to the health check. Not optimal, but it is a work-around.

When running a container, there is no facility to stop and error out from the health check. Currently the only work-around is to elevate a context with deadline to a panic within the scope of the health check. It would be better if dockertest would support a cancelable context and error out.