forcedotcom / salesforcedx-slds-lsp

SLDS LSP

The SLDS LSP is the link between the Core validator and the Visual Studio Code extension. It helps provide diagnostics, quick fixes, and other functionality based on recommendations provided by the validator.

If you are interested in contributing, please take a look at the CONTRIBUTING guide.

For more information on LSP’s please see the following guide: https://code.visualstudio.com/api/language-extensions/language-server-extension-guide

salesforcedx-slds-lsp's Issues

Allow for line-ignore option

It is a common scenario that CSS classes get constructed within a JavaScript getter.

It would be great to have an ignore option like // slds-ignore-next-line that allows the developer to disable validation, in the sense like ESLint or Prettier allow to ignore lines.

Turning Off the Utility Class Validator

Hey @billyma - the utility class suggestions provided by the validator aren't accurate. It is giving some questionable advice, so we should just disable it for now until we revisit this.

Resolve Security Audit Item - com.fasterxml.jackson.core:jackson-databind

Address security audit item identified by Github

Incorrect violation for card shadow

I got this violation error:
Items:

1. Style: .section-card {box-shadow : var(--sds-c-card-shadow, var(--lwc-cardShadow, 0 2px 2px 0 rgba(0, 0, 0, 0.1)))}

Violation List:
1.1) Instead of using static value for box-shadow: var(--sds-c-card-shadow, var(--lwc-cardShadow, 0 2px 2px 0 rgba(0, 0, 0, 0.1))), consider leveraging one of the following design token:

• var(--lwc-spacingNone, 0)

1.2) Instead of using static value for box-shadow: var(--sds-c-card-shadow, var(--lwc-cardShadow, 0 2px 2px 0 rgba(0, 0, 0, 0.1))), consider leveraging one of the following design token:

• var(--lwc-borderWidthThick, 2px)
• var(--lwc-spacingXxxSmall, 0.125rem)
• var(--lwc-varSpacingXxxSmall, 0.125rem)

However, I see the same in slds card documentation in this link :
https://www.lightningdesignsystem.com/components/cards/

Box Shadow	--sds-c-card-shadow--sds-c-card-shadow	String	0 2px 2px 0 rgba(0, 0, 0, 0.1)

Improve Invalid Classes / Tokens Algorithm

Improve Invalid Algorithm based on Issue Identified in VScode SLDS