Comments (3)
Agree, unseekable streams are already implemented in development branch. Could you verify, when using the latest development-code, that opening the file from networkstream actually works?
from fo-dicom.
gree, unseekable streams are already implemented in development branch. Could you verify, when using the latest development-code, that opening the file from networkstream actually works?
I use HttpClient.GetStreamAsync(url) to get the stream, but the stream not support get the length。So the stream returned by the GetStreamAsync method cannot be used directly to open a DICOM file。
from fo-dicom.
Ah ja, the UnseekableStreamByteSource assumes, that seeking is not supported. But this stream not even supports the Length property, which is even worse.
The quick fix is to download into a memorystream and then to parse using fo-dicom. The long fix, is to implement another version of ByteSource that uses streams without using Length. But to tell you the truth, this class internallly will have no other chance than to just download the data piecewise, buffer it into a memorystream and then do the parsing from that memorystream. That is also how UnseekableStreamByteSource is doing it.
So it will not be faster or less memory consuming because in both ways it has to download all the data, and the parsing will only be finished when all the data is ready downloaded. It will mainly be syntactic sugar because it saves you 1 line of code and newbie users are not surprised about a NotSupportedException when opening a DicomFile from a HttpResponseStream.
from fo-dicom.
Related Issues (20)
- How to monitor the time for a SCU client to transfer multiple files at a time on the SCP Server side HOT 3
- Code in fo-dicom to apply window width and center on an image HOT 1
- TCP listener stuck while processing TLS handshake HOT 4
- HTJ2K Throwing exception HOT 2
- The SCU client transmits images to the fo-dicom c-store-scp, and the speed decreases sequentially after each task is transmitted
- Korean Hangul characters incorrectly read from dicom file HOT 2
- fo-dicom v5 Dependency Injection Documentation HOT 3
- DicomServer performance regression HOT 6
- Microsoft Code Analysis HOT 2
- Creating a TCP connection using `DicomClient.SendAsync()` does not take `AssociationRequestTimeoutInMs` into account HOT 4
- DicomValidation for VR PN HOT 17
- dataset AddOrUpdate not find Encod args HOT 4
- Support proper encoding of strings with multi-valued encodings HOT 9
- DicomJsonConverter throws for non-DicomElements HOT 7
- Decimal String not adhering to standard? HOT 9
- Service stopped When Changing DICOM File Compression HOT 13
- Incorrect conversion between C# decimal and DICOM Decimal String HOT 1
- ISO 2022 IR 58 Encoded Strings Cannot Be Decoded Correctly HOT 3
- Performance impact in DicomDataset comparing HOT 4
- What is the plan for supporting .NET 8? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fo-dicom.