Coder Social home page Coder Social logo

Comments (4)

wjm23714 avatar wjm23714 commented on June 13, 2024

version fo-dicom 5.1.2

from fo-dicom.

wjm23714 avatar wjm23714 commented on June 13, 2024

The encoding should be done using the dataset encoding, taken from SpecificCharacterSet. If the character set cannot encode this string, it will get garbled. What encoding is set in your dataset?

I can set the SpecificCharacterSet property to display normally, but in the previous version 4.0, AddOrUpdate was able to set character sets, so why not now.

4.0 code:
public DicomDataset AddOrUpdate(DicomTag tag, Encoding encoding, params T[] values)
{
return DoAdd(tag, encoding, values, allowUpdate: true);
}

The version of for-dicom v5 no longer has this encoding parameter

from fo-dicom.

mrbean-bremen avatar mrbean-bremen commented on June 13, 2024

An encoding parameter for an individual item does not make much sense, because all items must be encoded with the dataset encoding according to SpecificCharacterSet. Setting the encoding for an item to another value would produce invalid DICOM. I guess this was the reason it was removed.
If you have set SpecificCharacterSet in your dataset, and your data is still encoded incorrectly, then this may be a bug. See also my last comment in #1785.

from fo-dicom.

wjm23714 avatar wjm23714 commented on June 13, 2024

Understood, thank you!

An encoding parameter for an individual item does not make much sense, because all items must be encoded with the dataset encoding according to SpecificCharacterSet. Setting the encoding for an item to another value would produce invalid DICOM. I guess this was the reason it was removed. If you have set SpecificCharacterSet in your dataset, and your data is still encoded incorrectly, then this may be a bug. See also my last comment in #1785.

from fo-dicom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.