Comments (4)
version fo-dicom 5.1.2
from fo-dicom.
The encoding should be done using the dataset encoding, taken from
SpecificCharacterSet
. If the character set cannot encode this string, it will get garbled. What encoding is set in your dataset?
I can set the SpecificCharacterSet property to display normally, but in the previous version 4.0, AddOrUpdate was able to set character sets, so why not now.
4.0 code:
public DicomDataset AddOrUpdate(DicomTag tag, Encoding encoding, params T[] values)
{
return DoAdd(tag, encoding, values, allowUpdate: true);
}
The version of for-dicom v5 no longer has this encoding parameter
from fo-dicom.
An encoding parameter for an individual item does not make much sense, because all items must be encoded with the dataset encoding according to SpecificCharacterSet
. Setting the encoding for an item to another value would produce invalid DICOM. I guess this was the reason it was removed.
If you have set SpecificCharacterSet
in your dataset, and your data is still encoded incorrectly, then this may be a bug. See also my last comment in #1785.
from fo-dicom.
Understood, thank you!
An encoding parameter for an individual item does not make much sense, because all items must be encoded with the dataset encoding according to
SpecificCharacterSet
. Setting the encoding for an item to another value would produce invalid DICOM. I guess this was the reason it was removed. If you have setSpecificCharacterSet
in your dataset, and your data is still encoded incorrectly, then this may be a bug. See also my last comment in #1785.
from fo-dicom.
Related Issues (20)
- Code in fo-dicom to apply window width and center on an image HOT 1
- TCP listener stuck while processing TLS handshake HOT 4
- HTJ2K Throwing exception HOT 2
- The SCU client transmits images to the fo-dicom c-store-scp, and the speed decreases sequentially after each task is transmitted
- Korean Hangul characters incorrectly read from dicom file HOT 2
- fo-dicom v5 Dependency Injection Documentation HOT 3
- DicomServer performance regression HOT 6
- Microsoft Code Analysis HOT 2
- Creating a TCP connection using `DicomClient.SendAsync()` does not take `AssociationRequestTimeoutInMs` into account HOT 4
- DicomValidation for VR PN HOT 17
- Support proper encoding of strings with multi-valued encodings HOT 9
- DicomJsonConverter throws for non-DicomElements HOT 7
- Decimal String not adhering to standard? HOT 9
- Service stopped When Changing DICOM File Compression HOT 13
- Incorrect conversion between C# decimal and DICOM Decimal String HOT 1
- ISO 2022 IR 58 Encoded Strings Cannot Be Decoded Correctly HOT 3
- Performance impact in DicomDataset comparing HOT 4
- What is the plan for supporting .NET 8? HOT 3
- Ability to cancel the store request in C-Get
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fo-dicom.