fmfpereira / dlamp Goto Github PK

Apache user and group change operations should be placed on the end.
This allows Docker to use the cached Debian Updates and PHP build.

libpng12-dev dependency does not work with PHP 7.2 image. The dependency must be updated to the special package wrapper libpng-dev.

xdebug does not support yet PHP 7.2. Until a table release is provided, PHP 7.1 must be suggested.

The PHP dockerfiles has the same structure/steps. Using PHP Version as argument will improve the project maintainability.

missing mysqli extension
Replace on Dockerfile

# INSTALL PHP EXTENSIONS
RUN docker-php-ext-install gd json mbstring pdo pdo_mysql zip opcache intl xsl

by

# INSTALL PHP EXTENSIONS
RUN docker-php-ext-install gd json mbstring pdo pdo_mysql mysqli zip opcache intl xsl

Explain why .gitkeep files exists.

The new xdebug version requires PHP version >= 7.0.0 and it fails in the CI build.

Since PHP 5.6 end of life is scheduled to be on 31 of December of 2018, it make sense to create a legacy branch with specific configurations for PHP 5.6, leaving the master branch with latest supported major version.
Sooner or later official PHP docker Hub will also drop the support for PHP 5.6.

CI build should also be split by PHP major/minor version.

1. 5.6
2. 7.0
3. 7.1
4. 7.2
5. 7.x (Each supported Official PHP Docker Hub supported major/minor version)

The build error log

WARNING: channel "pecl.php.net" has updated its protocols, use "pecl channel-update pecl.php.net" to update pecl/xdebug requires PHP (version >= 7.0.0), installed version is 5.6.33 No valid packages found install failed ERROR: Service 'web' failed to build: The command '/bin/sh -c pecl install xdebug' returned a non-zero code: 1

Windows version does not allows by default to user volumes outside C:. Other drives must be shared (depending Windows version).

Docker apache environment variables must exist and cannot be arguments.

The initial solution worked: Set the ENV variable with the ARG value.

Need to roolback this solution.

# For linux replace by your docker0 network ip (default)
# For docker4mac use "docker.for.mac.localhost" as xdebug.remote_host

This comments should use ";" instead of "#"

Sometimes there is the need to enable https when working with some external API's on stating environment.
Local environments https connectivity can be solved with ngrok [see #21].

As most projects will work locally, re-configuring apache container to enable ssl is complicated for most regular users and an overload for most developers.

The most simple and elegant solution is to create a new compose file that runs a nginx reverse proxy that forwards all https requests to the web container on http.

Create a step to step tutorial for users without docker experience.

xdebug configurations can be tricky for users without experience.

Explain xdebug configurations differences between Docker4Mac and Linux on the README.MD file.