Coder Social home page Coder Social logo

Comments (6)

timohubois avatar timohubois commented on September 25, 2024 1

@timohubois Ah looks like I also need to add the acf-field post type:

if (
        in_array(
            $postArr['post_type'],
            [
                'revision',
                'nav_menu_item',
                'attachment',
                'customize_changeset',
                'custom_css',
                'acf-field-group',
                'acf-field'
            ]
        )
    ) {
        return $data;
    }

It seems to work like that. Should it be fine like this?

You was 1 minute faster 😅

This should work, but maybe there are other edge cases. Will dive deeper into it this evening ✌️

from flynt.

timohubois avatar timohubois commented on September 25, 2024

Hey @aaronmeder,

many thanks for figure this out!

Did a short test and can confirm the behavior.

As quickfix, you can try to add 'acf-field-group' inside the theContentFix.php:

    if (
        in_array(
            $postArr['post_type'],
            [
                'revision',
                'nav_menu_item',
                'attachment',
                'customize_changeset',
                'custom_css',
                'acf-field-group'
            ]
        )
    ) {
        return $data;
    }

Will investigate this issue deeper asap.

Let me know if this works for you?

from flynt.

aaronmeder avatar aaronmeder commented on September 25, 2024

@timohubois Thanks for looking at this so quickly.

Hmm not fully: it seems to fix assigning Location rules, but it's still not saving field types for me.

from flynt.

aaronmeder avatar aaronmeder commented on September 25, 2024

@timohubois Ah looks like I also need to add the acf-field post type:

if (
        in_array(
            $postArr['post_type'],
            [
                'revision',
                'nav_menu_item',
                'attachment',
                'customize_changeset',
                'custom_css',
                'acf-field-group',
                'acf-field'
            ]
        )
    ) {
        return $data;
    }

It seems to work like that. Should it be fine like this?

from flynt.

timohubois avatar timohubois commented on September 25, 2024

@aaronmeder did some tests and excluded all acf related post types now, you can find the WIP branch here:
https://github.com/flyntwp/flynt/tree/543-flynt-v21-cannot-correctly-save-acf-field-groups

Let me know if the changes work for you?

from flynt.

aaronmeder avatar aaronmeder commented on September 25, 2024

@timohubois Works great for me!

from flynt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.