Minor front and back end issues about flynt

[LuisSR]

Thank you, @steffenbew! I owe you all an apology for the length of the issue. 😆

I'll wait for any update, and I'll be glad to help you if I can.

It wasn't mentioned in the issue, but the theme is amazing!

[steffenbew]

Hey @LuisSR, thanks a ton for your elaborate feedback! That's invaluable! Especially as it's so well documented and constructive. A couple of things are already on our list, some fixed already, others are new and some are conceptional thoughts we'll need to explain or rethink. Bear with us and give us some time to work through that! :)

[timohubois]

@LuisSR many thanks for the feedback and deep dive into Flynt.

I will shortly try to provide an update:

1. Back end issues

1.1. The theme can be activated in servers with a PHP version lower than 7.4 and leave the WP installation unusable

The style.css file has been modified to include a “Requires PHP” line in its header.

1.2. Add component button is not working as expected

The PR is merged and currently we have no known problems with it. If it does not work for you or you figure other issues, let us know or create a new PR with your changes, please.

1.3. The custom post type boilerplate is showing the ACF components interface, but components are not working on the frontend

We have updated the “pageComponents.php” file in relation to the /inc/customPostTypes/example.php, we oriented the code to the output from the GenerateWP Post Type Generator and just want to provide a starting point and we will discuss in the team about adding show_in_rest to this file.

1.4. Some printed variables via Twig need escaping

We are aware of this as well and would really appreciate your ideas and improvements in a new PR.

2. Front end issues

2.1. Support for Safari v14 and lower is not complete

Flynt is following a boilerplate approach and has decided not to make any changes in this area at this time. In the Discussions section, you may also be interested in a thread on legacy support: #484

2.2. Posts created with the core/classic block or with the TinyMCE editor do not have their content wrapped

That's a really good point, and I hadn't noticed that before. We will open an internal issue to find a solution. Feel free to post a PR as well.

2.3. Small styling issues around the post header and meta

2.3.1. An extra divider is shown in the post meta when a post has no categories

This should be fixed in current master branch.

2.3.2. Author box and categories/reading time are not correcty aligned

This should be fixed in current master branch.

2.3.3. Bleeding is missing when a post has no featured image

This should be fixed in current master branch.

2.4. Refine the aria-label on components that show a grid of posts

This should be fixed in current master branch.

3. Suggestions

3.1. The default block editor options might be overwhelming for content editors

We decided to keep the current behaviour and give the developer the freedom to do what they want without providing a specific path.

3.2. Group CSS media queries

Really interesting topic and approach! We currently feel it should be a developer decision to use this approach or not, so that we decided to not add this feature to the core – at the moment.

3.3. Included assets can be further compressed

We have further compressed the screenshots and updated them to the current master branch. Regarding the logo and the placeholder image, we would be really happy to see you hand optimized svg inside and further adjustments a new PR.

Final words

We were really happy to get such kind of a detailed issue and looking forward to your feedback in the future and further suggestions and maybe PRs 🚀

[timohubois]

Closed due inactivity. @LuisSR feel free to create a new issue, provide us more feedback or create a pr at any time!