Comments (2)
Hello @proteinone,
This is very similar to our approach, when adding editor styles.
We also add a new entry in the build-config.js because this will create a new, separate bundle.
/assets/editor-style.js would look like this:
import './editor-style.scss'
We usually only add global styles and not component specific ones. So that is why you do not necessarily need the import stuff in the editor-style.js.
We add editor styles on /inc/assets.php
add_action('admin_init', function () {
add_editor_style(Asset::requireUrl('assets/editor-style.css'));
});
We handle all asset loading in inc/assets.php and do not create an extra tinyMce.php, but this is just preference.
The Asset::requireUrl
is a helper to resolve the correct path of a given assets.
This most of the time just makes a difference when you run npm run build
, then all assets are revisioned, so they get a content hash added to their filename.
Thanks for the feedback! Glad you're enjoying Flynt!
from flynt.
Thanks @koukouchris !
Great to hear we were on the right path : )
I completely agree about the editor-style.js, we don't need component level styles either.
And the assets.php looks like a better place to enqueue the file also. Good idea.
from flynt.
Related Issues (20)
- Issue with "Module build failed" HOT 3
- Installer path in the composer.json HOT 1
- Flexible Content field inside a Component Not Working HOT 6
- Update Custom Colors in WYSIWYG ACF issue HOT 1
- Get url dist assets from twig HOT 1
- HTML Bloat with subfields HOT 1
- Will you be interested in a "social sharing" component? HOT 3
- Issue: npm install errors and warnings HOT 3
- Custom Function function 'n' not found or invalid function name HOT 1
- Trying to dynamically load a slider package, only if required HOT 1
- Unable to install NPM HOT 2
- composer install not working twig/cache-extension is abandoned HOT 15
- How to link scripts correctly HOT 4
- How to implement conditional_logic? HOT 2
- Local Environment (Flynt Next) HOT 2
- Is there a good way to bulk create posts with components? HOT 1
- Minor front and back end issues HOT 4
- Not Getting meta data in GridPostsLatest HOT 6
- Can it be used with a hosted wordpress with limited ssh? HOT 1
- Build Fails HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flynt.