SIGABRT occur in Embedder when using camera and video plugin same time about plugins

[bwikbs]

After a few observations, I think this is a problem that ExternalTextureGL is not normal state when DestructionCallback is called.

From now on, the situation which textures are updated competitively seems irrelevant.

[bbrto21]

@bwikbs I guess you are right

I observed a case that calling a destruction_callback registered with FlutterOpenGLexture after ExternalTextureGL is destroyed

ExternalTextureGL is immediately destroyed in FlutterUnregisterExternalTexture, however, the destruction_callback is referencing the destroyed instance in another thread

@xuelian-bai @xiaowei-guan

[xiaowei-guan]

@bwikbs I guess you are right

I observed a case that calling a destruction_callback registered with FlutterOpenGLexture after ExternalTextureGL is destroyed

ExternalTextureGL is immediately destroyed in FlutterUnregisterExternalTexture, however, the destruction_callback is referencing the destroyed instance in another thread

@xuelian-bai @xiaowei-guan
Ok, we check this issue.

[bbrto21]

A similar problem was found again when I test, which seems to require a mutex in the exturenal texture-related API of flutter-tizen.

(lldb) Process 947 stopped and restarted: thread 45 received signal: SIGCHLD
Process 947 stopped
* thread #22, name = 'Runner.dll', stop reason = signal SIGSEGV: invalid address (fault address: 0x14)
    frame #0: 0xb666fcec libpthread.so.0`__pthread_mutex_lock
libpthread.so.0`__pthread_mutex_lock:
->  0xb666fcec <+0>:  ldr    r3, [r0, #0xc]
    0xb666fcf0 <+4>:  movw   r2, #0x17f
    0xb666fcf4 <+8>:  push   {r4, r5, r6, lr}
    0xb666fcf8 <+12>: ands   r5, r3, #124
bt
* thread #22, name = 'Runner.dll', stop reason = signal SIGSEGV: invalid address (fault address: 0x14)
  * frame #0: 0xb666fcec libpthread.so.0`__pthread_mutex_lock
    frame #1: 0xa9ca23ac libflutter_tizen.so`std::__1::mutex::lock() + 8
    frame #2: 0xa9c81c8c libflutter_tizen.so`ExternalTextureGL::PopulateTextureWithIdentifier(unsigned int, unsigned int, FlutterOpenGLTexture*) + 28
    frame #3: 0xa84d3f10 libflutter_engine.so`std::__1::__function::__func<FlutterEngineInitialize::$_51, std::__1::allocator<FlutterEngineInitialize::$_51>, sk_sp<SkImage> (long long, GrDirectContext*, SkISize const&)>::operator()(long long&&, GrDirectContext*&&, SkISize const&) + 80
    frame #4: 0xa84dcc60 libflutter_engine.so`flutter::EmbedderExternalTextureGL::Paint(SkCanvas&, SkRect const&, bool, GrDirectContext*, SkFilterQuality) + 96
    frame #5: 0xa8807974 libflutter_engine.so`flutter::TextureLayer::Paint(flutter::Layer::PaintContext&) const + 60
    frame #6: 0xa8804dd4 libflutter_engine.so`flutter::ContainerLayer::PaintChildren(flutter::Layer::PaintContext&) const + 86
    frame #7: 0xa8807c74 libflutter_engine.so`flutter::TransformLayer::Paint(flutter::Layer::PaintContext&) const + 68
    frame #8: 0xa8804dd4 libflutter_engine.so`flutter::ContainerLayer::PaintChildren(flutter::Layer::PaintContext&) const + 86
    frame #9: 0xa8807c74 libflutter_engine.so`flutter::TransformLayer::Paint(flutter::Layer::PaintContext&) const + 68
    frame #10: 0xa8804dd4 libflutter_engine.so`flutter::ContainerLayer::PaintChildren(flutter::Layer::PaintContext&) const + 86
    frame #11: 0xa8806a92 libflutter_engine.so`flutter::PhysicalShapeLayer::Paint(flutter::Layer::PaintContext&) const + 210
    frame #12: 0xa8804dd4 libflutter_engine.so`flutter::ContainerLayer::PaintChildren(flutter::Layer::PaintContext&) const + 86
    frame #13: 0xa8807c74 libflutter_engine.so`flutter::TransformLayer::Paint(flutter::Layer::PaintContext&) const + 68
    frame #14: 0xa8804dd4 libflutter_engine.so`flutter::ContainerLayer::PaintChildren(flutter::Layer::PaintContext&) const + 86
    frame #15: 0xa8807c74 libflutter_engine.so`flutter::TransformLayer::Paint(flutter::Layer::PaintContext&) const + 68
    frame #16: 0xa8804dd4 libflutter_engine.so`flutter::ContainerLayer::PaintChildren(flutter::Layer::PaintContext&) const + 86
    frame #17: 0xa8807c74 libflutter_engine.so`flutter::TransformLayer::Paint(flutter::Layer::PaintContext&) const + 68
    frame #18: 0xa8804d76 libflutter_engine.so`flutter::ContainerLayer::Paint(flutter::Layer::PaintContext&) const + 86
    frame #19: 0xa8805b8a libflutter_engine.so`flutter::LayerTree::Paint(flutter::CompositorContext::ScopedFrame&, bool) const + 254
    frame #20: 0xa8803106 libflutter_engine.so`flutter::CompositorContext::ScopedFrame::Raster(flutter::LayerTree&, bool) + 218
    frame #21: 0xa8811a6c libflutter_engine.so`flutter::Rasterizer::DrawToSurface(flutter::LayerTree&) + 348
    frame #22: 0xa84f9d9a libflutter_engine.so`fml::MessageLoopImpl::FlushTasks(fml::FlushType) + 170
    frame #23: 0xa84fdb5c libflutter_engine.so`fml::MessageLoopLinux::Run() + 96
    frame #24: 0xa84f9cb6 libflutter_engine.so`fml::MessageLoopImpl::DoRun() + 26
    frame #25: 0xa84fd200 libflutter_engine.so`void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, fml::Thread::Thread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0> >(void*) + 216
    frame #26: 0xb666d438 libpthread.so.0
    frame #27: 0xb6c40e28 libc.so.6

[bbrto21]

closed by flutter-tizen/engine#81