Coder Social home page Coder Social logo

Comments (2)

swift-kim avatar swift-kim commented on June 6, 2024

The finalizers are being misused in tizen_bundle and tizen_rpc_port.

c.f.

_finalizer.attach(this, _context, detach: this);

A simple fix should be something like this:

@@ -20,20 +20,20 @@ class Bundle extends MapMixin<String, Object> {
   /// Creates an empty [Bundle].
   Bundle() {
     _handle = tizen.bundle_create();
-    _finalizer.attach(this, this, detach: this);
+    _finalizer.attach(this, _handle, detach: this);
   }
@@ -44,8 +44,9 @@ class Bundle extends MapMixin<String, Object> {
   }

   late final Pointer<bundle> _handle;
-  static final Finalizer<Bundle> _finalizer =
-      Finalizer<Bundle>((Bundle bundle) => tizen.bundle_free(bundle._handle));
+  static final Finalizer<Pointer<bundle>> _finalizer =
+      Finalizer<Pointer<bundle>>(
+          (Pointer<bundle> bundle) => tizen.bundle_free(bundle));

   static final List<String> _keys = <String>[];

from plugins.

JSUYA avatar JSUYA commented on June 6, 2024

Thank you for your comment.
I applied your comment to RP.
However, I couldn't think of an appropriate way in rpc_port case, so I wrapped it in a map.
I don't know if this is appropriate. If there is a good way, please let me know.

from plugins.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.