Coder Social home page Coder Social logo

floschu / control Goto Github PK

View Code? Open in Web Editor NEW
53.0 53.0 8.0 2.4 MB

๐ŸŽฎ coroutines flow based uni-directional architecture

License: Apache License 2.0

Kotlin 100.00%
android control controller coroutines jetpack-compose kotlin kotlin-flow library mutation-test testing unidirectional-data-flow

control's People

Contributors

floschu avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

control's Issues

Controller is not lazily started if only the effects field is accessed

The Controller is not started lazily if only the controller.effects getter is called (and no other property such as the controller.state is accessed or controller.dispatch is being called).

There may be the start() logic missing here:

private val effectEmitter: (Effect) -> Unit = { effect ->
val canBeOffered = effectsChannel.offer(effect)
if (canBeOffered) {
controllerLog.log { ControllerEvent.Effect(tag, effect.toString()) }
} else {
throw ControllerError.Effect(tag, effect.toString())
}
}

In a real world example, this would be relebant if e.g. in a transformer an onStart() with an emitEffect() should be called, which would then only be called after an action has been dispatched.

I'm just about to create a PR which adds a test for that as well as a possible fix, if the current behavior is not considered expected.

StateFlow

Kotlin/kotlinx.coroutines#1973

  • Consider using MutableStateFlow instead of ConflatedBroadCastChannel to back ControllerImplementation.state.
  • Consider whether Controller.state and Controller.currentState should be replaced by StateFlow

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.