florianalbert / financeobserver Goto Github PK

Is your feature request related to a problem? Please describe.
Right now, when including a navigation property in the repository, the type of the navigation property has to have the same type as a key as the parent entity does. For example, it is not possible to have the user entity type have a key of type System.Guid and the RegistrationConfirmation have a key of type System.Int32 and include the RegistrationConfirmation in the Query of a user.

Describe the solution you'd like
The key type of the included navigation property should get passed to the Inclusion object by a separate generic type argument.

Describe alternatives you've considered
You could also restrict all types inheriting from BaseEntity to have key type of System.Guid or another fix type. But this would limit the possibilities for the future to add entity types with key types that are more convenientfor their use case than the already fixed key type.

Additional context

Is your feature request related to a problem? Please describe.
When changing the code base in feature branch, it is possible to change or even break the existing behaviour, to add new unintended behaviour or even to introduce changes that make it impossible to compile the code base. This should get prevented, so that on the main branch is always a functioning version of the software.

Describe the solution you'd like
Add a GitHub Action that runs on a new PR to main, that tries to build the code base and run all tests. This should succeed as a required status check.

Describe alternatives you've considered
Since this is a well-known best practice, there are no real alternatives that are worth to consider.

Additional context
GitHub Actions Docs
Guide for .NET CI pipeline
Codecov to visualize code coverage of tests

Describe the bug
Since there is no support for the ExecuteUpdate and ExecuteDelete methods of EF Core with the in-memory provider, we should consider to remove the option of an in-memory database.

To Reproduce
Steps to reproduce the behavior:

1. Set environment variable FINANCE_OBSERVER_DB_PROVIDER to "InMemory"
2. Any bulk deletion or update functionalities should fail.

Expected behavior
All supported providers should support this feature.

Additional context