View Code? Open in Web Editor
NEW
Leaderboard is a webapp that allows users to add their names and scores and view leaderboard for everyone who has added theirs, this is a block project at @microverseinc
Home Page: https://flemton.github.io/leaderboard/dist
HTML 28.78%
JavaScript 39.09%
CSS 32.13%
leaderboard's People
Contributors
Watchers
leaderboard's Issues
Highligths :
Project WebPack is well configurated.
Project had ES6 and HTML/CSS/JS best practices.
APIs are well implemented.
Suggetions:
In my Browser submit scores didn’t seem to be added, but it does in presenter browser.
Issue currently in repo
Leaderboard table and/or data doesn't show when index.html is opened from dist folder
Data only shows when running webpack serve --open
For some or same reason, styles are not applied to the page
Good Job implementing the features, but there are some things that can be improved:
Improvements:
👤Bryan:
Please follow the layout for this project, you can use the wireframe provided in the instructions of the first part.
👤Kender:
I think in the index.html on line 9 you should remove it. As you use Webpack, it's not necessary to link your index file with the template
< script src ="index.js " defer type ="module "> </ script >
👤 Hans-Derly:
On line 4 in getScore.js, you can transform the result to JSON by using the .json() method.
const resj = await res . text ( ) ;
On line 11, in getScore.js, you can get the id of every iteration and use it to your LI tag.
scores . forEach ( ( score ) => {
Consider adding the event listener to the form instead of the button.
const submitBtn = document . querySelector ( '#submit' ) ;