flamingo-run / gcp-pilot Goto Github PK

In the GCP Pilot API base class here, the location is set, in the following priority:

• explicitly provided value
• default from a setting
• project default determined using AppEngine here

I think historically, GCP projects had a default AppEngine resource always available. Nowadays they don't (I think this only happened in the last year or so).

This code handles a NotFound exception silently, catching it to return None. This however, causes many problems later on, a variety of NotFound or PermissionDenied errors when trying to create or access resources at project/<project-id>/location/None/rest-of-it

I think that it's an antipattern allow the location value to be None at the end of the base init, we should know at the point of failure there's been an error rather than much later. How about somehting like:

class GoogleCloudPilotAPI(abc.ABC):
    def __init__(
        #stuff
    ):
        #stuff
        self.location = self._set_location(location=location)
        if location is None:
            raise NoLocationError("Couldn't set location from either explicit argument, GCP_LOCATION environment variable or from AppEngine")

?

So I've submitted an issue that never got touched, and assumed this project was dead... but have noticed a couple of version bumps recently.

Questions:

• is someone maintaining it?

• if so, who?

• where are the contributing guidelines and what's the release flow?

• the only issues on this board are raised by me, so where's the issues board you're using? And is there a release roadmap/plan?

• do you need help?

• have you considered getting sponsorship from Google (because really, this is a very good project compared to google's in-house "sdks" which are a nightmare to work with)?

(and because I noticed that you've deprecated support for python <3.10)

• are you aware google use ridiculously out of date python versions (e.g. dataflow only supports up to 3.9), so to get any kind of acceptance you'll need to keep some backward compatibility?