ObjectGroup on tiles not getting parsed from .tsx file about tiled.dart

[luanpotter]

A mistake, for sure! I imagine the extra tile never caused any issues, being empty.

[spydon]

0.7.3 is now released!

[spydon]

It definitely looks like an error on our side (https://doc.mapeditor.org/en/stable/reference/tmx-map-format/#tmx-objectgroup). Do you want to put up a PR that fixes it? :)

[lfraker]

@spydon sure thing, will submit one shortly. I didn't see a contributing guide - any process I need to adhere to for the PR, or for something this simple can I just submit the change if all tests pass?

[spydon]

@spydon sure thing, will submit one shortly. I didn't see a contributing guide - any process I need to adhere to for the PR, or for something this simple can I just submit the change if all tests pass?

The latter. :)

[lfraker]

@spydon I submitted a PR and included a new test case for this scenario: #32

While testing, I noticed something interesting. It seems like whenever Tiles are being parsed from a TileSet, an extra tile is always added.

The parsed result is initialized as a new TileSet before returning, (https://github.com/flame-engine/tiled.dart/blob/main/lib/src/tileset/tileset.dart line 141).
In the TileSet initialization code, _generateTiles is called which iterates from 0 to numTiles, inclusive, and thus appends an extra Tile that was not included in the input file (https://github.com/flame-engine/tiled.dart/blob/main/lib/src/tileset/tileset.dart line 219):

for (var i = 0; i <= tileCount; ++i) {
      if (t.localId == i) {
        tiles.add(t);
        if (iterator.moveNext()) {
          t = iterator.current;
        }
      } else {
        tiles.add(Tile(localId: i));
      }
    }

I was curious what the reason was for the extra Tile. Should we simply ignore it?

[spydon]

Fixed by #32

[lfraker]

@spydon @luanpotter, forgot to update the package version in the PR. Are you able to bump the version so I can pull the latest package, or is there a release process for publishing?

Hoping to use this fix in a project I'm working on!

[spydon]

@spydon @luanpotter, forgot to update the package version in the PR. Are you able to bump the version so I can pull the latest package, or is there a release process for publishing?

Hoping to use this fix in a project I'm working on!

I can do a release later today hopefully (you don't bump the version in the separate PRs, it's a separate process).

[lfraker]

Awesome, thank you!