Comments (12)
I think we dont have any example using that field, so it's very likely broken. I will test this against the new flame_tiled
from tiled.dart.
@ufrshubham interesting, I'm willing to take a look later today.
from tiled.dart.
Any news?
No news, if anyone want to take on this feel free! :)
from tiled.dart.
tiled.dart/lib/src/tileset/tileset.dart
Lines 212 to 213 in dece94d
This is the reason. Spacing shouldn't be added to the source rectangle. Removing the spacing fixes the issue.
from tiled.dart.
@spydon I just tried to test that branch but the problem still persists. After debugging I found out that it was failing because spacing and margin parameters were not copied in _checkIfExtenalTsx()
method.
Edit: This is required only for cases where an external tileset file is used. For embedded tilesets, original fix should be enough.
from tiled.dart.
I think we dont have any example using that field, so it's very likely broken. I will test this against the new flame_tiled
Ok cool!
from tiled.dart.
Any news?
from tiled.dart.
tiled.dart/lib/src/tileset/tileset.dart
Lines 212 to 213 in dece94d
This is the reason. Spacing shouldn't be added to the source rectangle. Removing the spacing fixes the issue.
Do you want to put up a PR for the fix? :)
from tiled.dart.
I see a PR is open for this but it is not approved. Is that not the correct fix for this issue?
from tiled.dart.
I see a PR is open for this but it is not approved. Is that not the correct fix for this issue?
I think it was just forgotten. Would be good if someone depended on the branch and tried the fix.
from tiled.dart.
This has been fixed with pull request #41 and I believe has been verified by @ufrshubham
from tiled.dart.
This has been fixed with pull request #41 and I believe has been verified by @ufrshubham
Yes, I've tested that PR and it works.
from tiled.dart.
Related Issues (20)
- parser.dart not imported in v0.7.0 HOT 4
- How to get a Tile's x, y coordinates in 0.7.0? HOT 1
- Bit shifts processing tile flips break down around gid=>2^28 HOT 3
- ObjectGroup on tiles not getting parsed from .tsx file HOT 10
- Issue when parsing multiple external tilesets. HOT 10
- Bug in objectalignment parsing
- The Template cannot be properly parsed. HOT 1
- Make it easier and more efficient to access a property by name HOT 5
- Bump xml to latest (6.1.0) HOT 2
- Parse JSON produces no data inside layers
- FormatException when parsing a tmx file HOT 2
- Ability to access the image rect for tiles HOT 2
- Json tile map parsing null HOT 4
- [proposal] Omit empty TiledImage from TiledMap.tiledImages HOT 2
- Dart SDK compatibility HOT 15
- Test Function on custom TsxProvider`s HOT 1
- Map Export HOT 2
- Template parsing does not work HOT 1
- Blurry tiles on flutter web HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tiled.dart.