Coder Social home page Coder Social logo

Comments (5)

kyle-ssg avatar kyle-ssg commented on June 22, 2024 1

Hey @harenlewis, going to schedule some time Friday to sort this. I’m sure it’ll be quite obvious when I look at it.

Ofcourse if you want to look at doing a pr in the meantime that would be amazing!

from flagsmith-js-client.

harenlewis avatar harenlewis commented on June 22, 2024

Hi @kyle-ssg any updates or workaround for this issue, I'm planning to use it for my react frontend application and discard unnecessary render caused by the onChange trigger.

Let me know if I can help in any way, would not mind working on it and submitting a PR.

from flagsmith-js-client.

harenlewis avatar harenlewis commented on June 22, 2024

@kyle-ssg Hey thanks for the reply. Sure I've gone through the code, can you help me setup the development env, I mean how to get the library running for development.
Or if there's any doc that I can refer to?

from flagsmith-js-client.

kyle-ssg avatar kyle-ssg commented on June 22, 2024

@harenlewis sorry for the delay, a few things.

I've deployed version 0.2.0 on bullet-train-js-client and react-native-bullet-train to resolve this issue.

  • I've added instructions on developing the client library locally.
  • You're correct the associated PR did break this, however old flags needed to be immutable. The above code snippet will now work.
  • params now contains a flagsChanged and traitsChanged boolean which is based on a deep equals of before and after.

If you have any questions or comments just let me know and I'll reopen this!

from flagsmith-js-client.

harenlewis avatar harenlewis commented on June 22, 2024

@kyle-ssg Thanks for resolving this. I've tested it out and it works perfectly!

from flagsmith-js-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.