Comments (5)
Hey @harenlewis, going to schedule some time Friday to sort this. Iβm sure itβll be quite obvious when I look at it.
Ofcourse if you want to look at doing a pr in the meantime that would be amazing!
from flagsmith-js-client.
Hi @kyle-ssg any updates or workaround for this issue, I'm planning to use it for my react frontend application and discard unnecessary render caused by the onChange trigger.
Let me know if I can help in any way, would not mind working on it and submitting a PR.
from flagsmith-js-client.
@kyle-ssg Hey thanks for the reply. Sure I've gone through the code, can you help me setup the development env, I mean how to get the library running for development.
Or if there's any doc that I can refer to?
from flagsmith-js-client.
@harenlewis sorry for the delay, a few things.
I've deployed version 0.2.0 on bullet-train-js-client and react-native-bullet-train to resolve this issue.
- I've added instructions on developing the client library locally.
- You're correct the associated PR did break this, however old flags needed to be immutable. The above code snippet will now work.
- params now contains a flagsChanged and traitsChanged boolean which is based on a deep equals of before and after.
If you have any questions or comments just let me know and I'll reopen this!
from flagsmith-js-client.
@kyle-ssg Thanks for resolving this. I've tested it out and it works perfectly!
from flagsmith-js-client.
Related Issues (20)
- Support for manifest 3? HOT 4
- Add Github Action to auto publish releases to npm
- useFlags doesn't trigger re-render after identify. HOT 15
- defaultFlags: Property 'id' is missing in type '{ enabled: true; }' but required in type 'IFlagsmithFeature'.ts HOT 4
- Calling getAllFlags from useFlagsmith in react throws an error HOT 3
- TypeError: Cannot convert undefined value to object - when calling getOwnPropertyNames in analyticsFlags() HOT 3
- Implement OpenFeature provider HOT 1
- When `cacheFlags` is on, `identity` is not updated in localStorage cache after being updated in practice HOT 6
- SDK connects to realtime.flagsmith.com HOT 1
- Provided default flags should be used when unable to establish connectivity to Flagsmith API HOT 3
- Consider updated_at timestamp with SSE HOT 1
- Reduce busy analytics / storage logs
- 3.18.0 breaks tests with EventSource ReferenceError HOT 1
- Add loading state / hook
- Ignore undefined traits when attempting setTrait(s)
- Case sensitive flags are lower cased when trying to retrieve values
- isLoading never updates to false if flag is disabled (React useFlagsmith hook) HOT 5
- Clear cache when calling logout() HOT 5
- the value obtained is sometimes not appropriate HOT 2
- Don't call getFlags() if the identity set is the same HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flagsmith-js-client.