isLoading never updates to false if flag is disabled (React useFlagsmith hook) about flagsmith-js-client

[Marlon-Buckley]

Following up on this, I discovered that If I have another flag inside useFlags(), and if that flag is always enabled in the Flagsmith console, the isLoading property behaves as I'd expect.

export default function Home() {
	const flagsmith = useFlagsmith();
	const flags = useFlags(['first_feature', 'foo']);

	useEffect(() => {
		document.title = 'Home';
	}, []);

	if (!flagsmith.isLoading) {
		return (
			<>
				{flags.first_feature.enabled && (
					<p>{flagsmith.identity} has first_feature flag enabled🎉</p>
				)}
				<h1>home page</h1>
			</>
		);
	}
}

So in this version, the first_feature flag is disabled on the Flagsmith console and the foo flag is enabled. flagsmith.isLoading starts out as false, then changes to true and finally ends up false as I'd expect.

[kyle-ssg]

Apologies for the silence on this @Marlon-Buckley @vik-buchinski, I've tested internally and am happy with the current PR. I'll be getting this reviewed by our team, in the meantime there is a beta version on npm - 3.18.5-beta7

[kyle-ssg]

Hey @Marlon-Buckley, isLoading was actually intended just for internal use at this time, hence why it wasn't referenced in our docs. We do have plans for adding a strategy for loading state as it's a bit more complex than just isLoading when you consider cache and default flags.

Please refer to #169, if it interests you I could publish a beta for this to see if it fits your usecase?

[Marlon-Buckley]

Hi @kyle-ssg thanks for explaining, that makes sense. I'd be happy to test out the changes in #169, if that's not too much trouble!

[vik-buchinski]

@kyle-ssg Hello!
Any progress or deadline for releasing #169 ?

Thanks in advance!