fivethirtyeight / d3-pre Goto Github PK

Ran into an issue where the headless browser was throwing en error (related to encoding; the error wasn't being replicated by chrome) and so not rendering the svg.

Aaron was able to resolve it by figuring out the port of the headless browser and finding the error. Is that port always the same and should we expose it in the documentation so people can check to see if there are any errors when things don't seem to be working?

Yoooooo, I spent like 3 hours digging through browserified & minified fivethirtyeight production code trying to figure out why the 2016 forecast page didn't render graphs when I embedded it in an Electron app. (Trying to make a wall display of the election forecast using y'alls visualizations).

Eventually I figured out it was because of this line: https://github.com/fivethirtyeight/d3-pre/blob/master/src/index.js#L17 which recognizes electron even if I disable nodeIntegration or isolate the page in a webview tag

Easy fix for me, I can just change the userAgent. But I thought I'd let you know for the miniscule chance that it might be useful for you. I would suggest using something like is-electron-renderer. Feel free to close this issue if you don't care, though.

Thank you for this awesome tool.

I ran into an issue using this for a chart I'm making using D3 4.0 code. In the browser I'm getting this error message: Uncaught TypeError: Cannot read property 'axis' of undefined, which points to line 43 in browser.js: d3.svg._axis = d3.svg.axis;.

The new API docs use axisTop, axisLeft, axisRight and axisBottom. Is there a workaround or does this tool strictly worth with D3 V3 code?