fiskaly / fiskaly-kassensichv-client-ios Goto Github PK

Hey there.
I was trying to run the project with only changes the TSS UUID / Client UUID / API Key / API Secret. But the FiskalyKassensichvSmaInvoke() will cause the app crashed when passing the string {\"method\":\"version\",\"jsonrpc\":\"2.0\"} as params.

Would be nice if some detail description could be added into framework explain what kind of string should be pass into the function here.

Hey guys,

I was try to use the client framework from our project. But response was not alway as expected. And I checked in Client.swift Line which case all Http request method is GET

Maybe a change like this can fix it:

request = URLRequest(url: components.url!)
To be
request.url = components.url!

Bug Report

Just a simple one here. During the handling of this code in the client.swift example code an oversight means that the completion handler can be called twice.

For example line 213 is called as a 'default' at the bottom of the nested code. The if/else tree stack has one option called and then line 213 is called after. This leads to two responses, one of which will always be a success.

I understand this is example code but it helps to provide a full implementation to which we should build against.

Steps To Reproduce

Make a TSS request and put breakpoints on lines: 196, 199, 204, 207, 210 and 213. One of the first 5 will always be called IN ADDITION to line 213.

Expected behavior

Only one of these should be called out of all 6. I would probably just delete line 213.

Feature

Cocoapods is the most commonly used dependency manager and it would be great to get the framework distributed in this way so that we can keep it updated easily

Motivation

Currently we have to install the library manually and this can be error prone and is difficult to watch for updates. With cocoapods its very simple to keep up to date because we can simply call 'pod update/install' for the latest version.

Pitch

This would improve your ability to distribute the framework to b2b customers.