Coder Social home page Coder Social logo

first-steps-in-ddd-solutions-dotnet's People

Contributors

andrewharmellaw avatar bapostma avatar barryptw avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar

Forkers

emilianb mkhatana natashasmirnova alzech nikbakhts kendallroden rtigithub asantos2000 davidssl cristian-oncaffeine eqsoftdev tanjaro1 paulostradioti onurbolukbas xlevel gamousquesort webroi11 brettstedford vikramvee at-education lcshan sswietoniowski basehope srihari-sridharan-tw akg-dotnet-dev merkt

first-steps-in-ddd-solutions-dotnet's Issues

Using more idiomatic dotnet

Thanks for the course!

first-steps-in-ddd-solutions-dotnet/src/JusticeApp/PNCId.cs

Line 7 in 31864d3

public string Value { get; private set; }

Readonly properties don't need private setters.
Also, in C# 9+, immutable classes are best represented as records.

first-steps-in-ddd-solutions-dotnet/src/JusticeApp/Investigation/PreChargeDecisionCase.cs

Line 33 in 31864d3

return new HashSet<Suspect>(_offenceAdvice.Keys);

Use ToHashSet

first-steps-in-ddd-solutions-dotnet/src/JusticeApp/Investigation/PreChargeDecisionCase.cs

Lines 15 to 18 in 31864d3

foreach (Suspect s in suspects)
{
_offenceAdvice.Add(s, null);
}

define _offenceAdvice using suspects.ToDictionary

first-steps-in-ddd-solutions-dotnet/src/JusticeApp/Investigation/PoliceInvestigationDetails.cs

Lines 12 to 15 in 31864d3

public IReadOnlyCollection<Suspect> Suspects
{
get => _suspects;
}

Readonly properties can use an arrow directly Suspects => _suspects

first-steps-in-ddd-solutions-dotnet/src/JusticeApp/Preparation/PoliceCaseFile.cs

Lines 14 to 15 in 31864d3

Defendants = new HashSet<Defendant>();
Defendants.Add(defendant);

you can add things without explicit Add on explicit instantiation. new HashSet<Defendant> { defendant }

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.