Coder Social home page Coder Social logo

Comments (4)

pbrubeck avatar pbrubeck commented on July 25, 2024

I think we should address this issue by introducing a reconstruct(mesh) method for function spaces, and using it here, as @wence- suggested

if isinstance(V, firedrake.functionspaceimpl.FiredrakeDualSpace):
V = firedrake.functionspace.DualSpace(mesh, V.ufl_element())
else:
V = firedrake.FunctionSpace(mesh, V.ufl_element())

from firedrake.

pbrubeck avatar pbrubeck commented on July 25, 2024

Also I don't think we have a @coarsen.register for MixedFunctionSpace

from firedrake.

JHopeCollins avatar JHopeCollins commented on July 25, 2024

Also I don't think we have a @coarsen.register for MixedFunctionSpace

Does MixedFunctionSpace need it's own dispatch if the mixed-ness is being dealt with inside DualSpace and FunctionSpace?

from firedrake.

pbrubeck avatar pbrubeck commented on July 25, 2024

Does MixedFunctionSpace need it's own dispatch if the mixed-ness is being dealt with inside DualSpace and FunctionSpace?

I did not see why we should keep the impl.FunctionSpace dispatch, therefore there's no need to add one for impl.MixedFunctionSpace. These two are abstract classes that do not carry the actual geometry. The coarsen dispatch to deal with both primal and dual spaces on a mesh should be on WithGeometryBase.

from firedrake.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.