Coder Social home page Coder Social logo

Comments (3)

connorjward avatar connorjward commented on July 25, 2024

@nbouziani what are your thoughts?

Regarding the proposed inheritance change I think that that would be extremely disruptive in UFL, even if it is technically the right approach.

from firedrake.

jrmaddison avatar jrmaddison commented on July 25, 2024

Using a Function for the simplified derivative is also complicated by #3346.

from firedrake.

jrmaddison avatar jrmaddison commented on July 25, 2024

After some digging I think the relevant lines are 66-70 at https://github.com/FEniCS/ufl/blob/0f2cb2199476f9aaf98bbd942a22aa472ce5c639/ufl/action.py#L66. Removing these fixes the first case (after an update to _check_function_spaces).

I also see that this code has a double initialization bug -- if the returned right or left are themselves Actions then Action.__init__ will be called for them again (https://docs.python.org/3/reference/datamodel.html#object.__new__).

from firedrake.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.