finos / legend-juju-gitlab-integrator Goto Github PK

Currently, we're only running lint and unit tests on presubmit. Unit tests are useful, but insufficient in ensuring that new pull requests do not break the current charm.

The integration tests should:

• build and deploy the charm.
• set the gitlab-secret-id and gitlab-secret-name config options and expect that the charm will become Active.
• add the necessary (tester) charms and relations for the following relations: legend-studio, legend-sdlc, legend-engine.
• check that the charm updates their relation data with the necessary Gitlab connection details.
• update the charm's gitlab-secret-id / gitlab-secret-name and assert that the related charms' relation data is updated.
• check that the Legend Engine configuration files are updated when the above relations are updated with new data.
• call the get-redirect-uris action and assert that it contains the Callback URIs given by the related charms.

Currently, if the charm is configured to use a private gitlab instance, it will create the Gitlab Application which will be then used by FINOS Legend. When the Application is created, it will also configure the Callback URIs received from the related Legend applications.

However, if the Callback URIs change due to various reasons (external-hostname / enable-tls config options have changed), this charm does not update those Callback URIs, which are mandatory for the Legend applications authorization.