github_auth.js about maxi-medium

[emilyb7]

also, is there are reason why you compare the whole object here?

const isUserInfoTheSame = Object.keys(userDb).every(key => {
              return userDb[key] == user[key];
            });

surely we could just compare the github id first to check whether the user exists?

in any case, you don't need the curly brackets in the function within every above (unless this is a conscious style choice...)

[finnhodgkin]

The 'isUserInfoTheSame' check is just to see if any of the information from Github has changed between logins. That way we don't make unnecessary database calls repeatedly for the same user. Good shout on the curlies and the insane amount of line breaks :)