Comments (2)
also, is there are reason why you compare the whole object here?
const isUserInfoTheSame = Object.keys(userDb).every(key => {
return userDb[key] == user[key];
});
surely we could just compare the github id first to check whether the user exists?
in any case, you don't need the curly brackets in the function within every
above (unless this is a conscious style choice...)
from maxi-medium.
The 'isUserInfoTheSame' check is just to see if any of the information from Github has changed between logins. That way we don't make unnecessary database calls repeatedly for the same user. Good shout on the curlies and the insane amount of line breaks :)
from maxi-medium.
Related Issues (20)
- Update user info in the database if it is different
- No defence against user injected frontend scripts
- Validate user inputs on the back end
- Cookie not setting in Chrome after user authorisation for the first time
- Login form error handling HOT 1
- Slow database testing due to connection idling
- Add tests to server routes
- Style the 'login with github' button
- Render article text in a `div` tag to allow nice formatting
- Add a markdown header to the write a story route
- Add search functionality to find interesting articles
- Add profile pages for maxi-medium users
- Should there be a logout button? HOT 2
- The login pop up looks sick HOT 2
- Do you use the parallel and waterfall helper functions? HOT 1
- improve readability of login_dialog.hbs
- markdown
- improve test coverage
- nice labelling of issues HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from maxi-medium.