finnhodgkin / maxi-medium Goto Github PK

I can't see you using these at any point, so it might be worth removing them?

Our current user stories don't reflect the addition of OAuth.

it's nice that you're labelling your issues, especially the priorities

I see the js file to get markdown set up, but it's not been implemented. Would be cool to see this working

Set up validation schema

At the moment users can freely add posts containing '<script>' tags... Super easy to break our pages with infinite loops, etc.

in terms of flow it would be really good to have a log out button. Probably not top on priorities, though

A potential fix would be to add prevent default and a default login link.

Although the app has good validation for bad form values - passwords under 6 chars, etc. - the validation for not finding a username, or for an incorrect password isn't user friendly at all.

Currently no user stories, goals or stretch goals are ticked to show completion.

Display error messages on the front end

Currently our routes are a bit messy...

• add oauth functionality to our database

It'd be good to have higher code coverage with tests. We also didn't focus on this either though so I get why it is where it is, just something you could work on later :)

login_dialog is really dense and not pleasant to read. Maybe break out your handlebars and html syntax onto different lines/ indentations.

Also, I really like the idea of looping through an array of dom elements and toggling the modal!

just wanted to say it looks really good

There's some really nice stuff in here :)

I like this
const { access_token } = qs.parse(githubAccessTokenResponse);
👍🏻

some things to improve:

• lots of empty lines - use a linter?
• line 24 is really long and unreadable, you could use the url module to format your url and keep your lines shorter?
• further down, the code gets less readable. You have a lot of nested callbacks! Have you thought about how you could separate this out into independent functions?