finnhodgkin / maxi-medium Goto Github PK
View Code? Open in Web Editor NEWHome Page: https://maxi-medium.herokuapp.com/
Home Page: https://maxi-medium.herokuapp.com/
I can't see you using these at any point, so it might be worth removing them?
Our current user stories don't reflect the addition of OAuth.
it's nice that you're labelling your issues, especially the priorities
I see the js file to get markdown set up, but it's not been implemented. Would be cool to see this working
Set up validation schema
At the moment users can freely add posts containing '<script>' tags... Super easy to break our pages with infinite loops, etc.
in terms of flow it would be really good to have a log out button. Probably not top on priorities, though
A potential fix would be to add prevent default and a default login link.
Although the app has good validation for bad form values - passwords under 6 chars, etc. - the validation for not finding a username, or for an incorrect password isn't user friendly at all.
Currently no user stories, goals or stretch goals are ticked to show completion.
Display error messages on the front end
Currently our routes are a bit messy...
It'd be good to have higher code coverage with tests. We also didn't focus on this either though so I get why it is where it is, just something you could work on later :)
login_dialog is really dense and not pleasant to read. Maybe break out your handlebars and html syntax onto different lines/ indentations.
Also, I really like the idea of looping through an array of dom elements and toggling the modal!
just wanted to say it looks really good
There's some really nice stuff in here :)
I like this
const { access_token } = qs.parse(githubAccessTokenResponse);
๐๐ป
some things to improve:
url
module to format your url and keep your lines shorter?A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.