finaps / eventsourcing Goto Github PK

Current behavior:
When using multiple Apply methods EFCore provider doesn't preserve their order on insert.

My code that fails

        Apply(new CompetitionCreatedEvent());
        Apply(new CompetitionNameSetEvent(name));
        Apply(new CompetitionLogoSetEvent(logo));

EF then try to sort entities alphabetically on insert thus getting into constraint violation

You can check issue here dotnet/efcore#11686
This issue lead me to PR dotnet/efcore#25874 where inserted entities are ordered using StringComparer.Ordinal

After digging source code found the piece of code that cause this

	case AddEventsAction(var events):
    	_store.Context.AddRange(events);
        break;

Proposed solution:
As a solution I can only think of Bulk insert wrapped in transaction. Maybe you'll find a better way

The NotNull Constraints generated for each Event fail when Event.PropertyName is not mapped to nameof(Event.PropertyName).

This happens when for example two Events with the same property name are mapped to the same table, but don't inherit this property from a shared base class. (see here for more info)

The NotNull implementation should be aware of EF.Core's naming conventions.