Coder Social home page Coder Social logo

Comments (2)

lyswifter avatar lyswifter commented on June 9, 2024

@Stebalien I wonder if I could just change the UnvalidateBitField to BitField to avoid repeated validating actions. I am a little confused about validating them in parameters and return values mean.
DeepinScreenshot_select-area_20220905111039

from builtin-actors.

Stebalien avatar Stebalien commented on June 9, 2024

I mean, replace all instances of UnvalidatedBitField with BitField in actor method parameters/return values. E.g.

#[derive(Serialize_tuple, Deserialize_tuple)]
pub struct ExpirationExtension {
pub deadline: u64,
pub partition: u64,
pub sectors: UnvalidatedBitField,
pub new_expiration: ChainEpoch,
}

Basically, any type taken/returned by a method called in an invoke implementation like

fn invoke_method<BS, RT>(
.


The rational is:

  • Validate all external inputs.
  • Avoid parsing/validating internal state on-load.

from builtin-actors.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.