ffxiv-teamcraft / ffxiv-teamcraft

A ffxiv tool to handle collaborative crafts easily

FFXIV Teamcraft

Collaborative crafting tool for Final Fantasy XIV

https://ffxivteamcraft.com

Discord for support, bugs discussion and contributors: https://discord.gg/r6qxt6P

Development

License

MIT

Responsive tooling

We're using @angular/flex-layout for responsive tooling, their wiki is available on the link below.

https://github.com/angular/flex-layout/wiki/Responsive-API

Contribute

Contributions guidelines can be found inside CONTRIBUTING.md file.

ffxiv-teamcraft's Issues

Can't remove recipe from list

Adaptation des niveaux par rapport a ceux du personnage non fonctionnel (prod)

Lorsque je me connecte avec mon personnage et que je click sur "adapt to character", rien ne se passe
Errors dans le log :

• "ERROR TypeError: Cannot read property 'classjobs' of undefined"
• "Error: permission_denied at /users/pft0pxNd9Kdpf7rxoRD4OyjT7Bx2/lists/-KssVFhcl6IEhlOwYk6m: Client doesn't have permission to access the desired data."

list creation field marked as invalid after creating the list

Topic on reddit: https://www.reddit.com/r/ffxivteamcraft/comments/6yh1tg/bug_chrome_creating_list_shows_error_still_creates/

Steps to reproduce:

• Go to lists view.
• Create a list.
• The field is marked as invalid, but you just created the list with a valid name.

Searching only returns a list of "name missing" items

When I search for something all items in the list are named "missing name" and clicking them redirects me to the start page.

feat: tier system

For the precraft category, we need a tier system or something to know which craft needs some other precrafts.

Reddit request comment: https://www.reddit.com/r/ffxiv/comments/741eob/ffxiv_teamcraft_20_more_features_a_lot_more_to/dnuwj9r/

Searching Twice, Does not clear list if empty result

When searching twice does not clear the list when the first search populates the list, and the second has no results

Steps to reproduce

1. search "Iron Awl"
2. See results
3. add s creating "Iron Awls"
4. previous search not cleared

Add a different colored icon for gathering

In game client, Mining and Quarrying, like Harvesting and Logging have a different color. Would be sweet if we can have this as well in our lists <3

style: better design for mobile

At the moment, the application (looking at you, list page) is very ugly in mobile design, adding a responsive design for this kind of device would be a big plus.

add the ability to save one's list

When you check a list someone linked to you, it would be better to be able to "save" it in kind of a favorite section, to be able to find these lists easily.

removing value from amount field removes the item from the list

When you want to edit the amount of items in a list (/lists view), if you clear the field to type a new value, it will remove the item as the field value will be 0.

feat: Unspoilerd/Ephemeral nodes timer

A little time under or near the "unspoiled" item could be great. Not sure if it would be easy, but even a simple timer with no sounds or popup would be the best right now.

Search recipe paging not supported

As xivdb makes use of a paging system, searching for something like "healing" returns 675 results, which means 12 pages.

As we're filtering items to return only the craftable ones ans we're not implementing the paging system, the number of items shown is 3 for "healing", while it should be more.

The solution are to either implement xivdb's paging system, or to wait for garlandtools's new searching api.

add the ability to change language

See https://www.reddit.com/r/ffxiv/comments/6u1jxw/collaborative_crafting_tool_ffxiv_teamcraft/dlp74er/

allow multiple lists opened button seems always on

style: change list details view for a more compact version

see: https://www.reddit.com/r/ffxiv/comments/6yfyg0/ffxiv_teamcraft_first_release/dn3zlwv/

As the reddit comment pointed out, having a more compact display version can be a really good plus, the hability to see more informations without having to play with browser zoom can be good for users.

The idea is to either change the current display or add a compact toggle, to toggle display to either compact or full.

We have to take in consideration the fact that the compact version might need to change font size or things like that, as we don't want to hide important informations.

Add loading icon for XHR Requests

Add source icon (hunts, dungeons, etc) for Desynthesis

perf: reduce lists size

The current average size for a list is 41Kb which is pretty big.

Here is the list of everything that can be made to reduce lists size, along with the estimated size reduction:

• Remove every single name property, loading names from static json files (40%).
• Remove addedAt property (10%).
• Change icon property for a simple id instead of the full path.
• Use only what's needed in node property (https://gist.github.com/Supamiu/80996ce98c79818cda53b5861cba2675#file-ffxivteamcraft-kthbvbohvbdch7ladl7-export-json-L36) some things like items aren't needed at all.

An example list (JSON) can be found here: https://gist.github.com/Supamiu/80996ce98c79818cda53b5861cba2675

Add a proper home page

I'm thinking of adding a "list counter" to the main page, showing how many lists we currently have (we need Firebase Cloud Function for that).

The main interest of such a thing is to increase the "trust factor" of the application, because as a user, if you see that 1k+ lists are currently on the website, it's a proof that the website is useful.

feat: fork list feature

The fork list feature allows a user to say "Oh I like this list, I'd like to have my own exactly like this one, but with my progression".

It basically creates a copy of the given list and links it to the users's account, making the user own a copy of the list. If the original list is modified, modifications won't be applied to lists forked from this one.

refactor: split services and explode logic for a better developer experience

As it is right now, there's no comments on the code and it's not very well organized, this has to be changed asap to enable easier contributions.

feat: ability to create a 'friends list' with the intent that you can see who can craft/provide items at a glance

From: https://www.reddit.com/r/ffxiv/comments/6yfyg0/ffxiv_teamcraft_first_release/dmn3taw/?context=10000

As a logged in user I would like the ability to see which of my crafter/gatherer friends would be able to make/gather an item for me.

removing item from the list sometimes leaves materials in it

When removing an item from the list, materials are sometimes remaining.

Steps to reproduce:

• Create a List
• Add Persimmon Leaf Sushi in it
• Change the amount for a high one (50+)
• Add another item to the recipe
• Remove Persimmon Leaf Sushi
• Some fishes will still be in the materials required

feat: rename a list

Removing a list from favorites corrupts the entire list

Steps to reproduce:

• Log in to your account
• Add https://ffxivteamcraft.com/list/N9iJj4tdcBOQpxH7qGdrRxJpxa32/-KvZCmdjfczBo73-P5xO as favorite
• Add https://ffxivteamcraft.com/list/N9iJj4tdcBOQpxH7qGdrRxJpxa32/-Kvc8RQN2t2wZYDowhGG as favorite
• Remove https://ffxivteamcraft.com/list/N9iJj4tdcBOQpxH7qGdrRxJpxa32/-Kvc8RQN2t2wZYDowhGG from favorites (uncheck the heart)
• Check your favorites page

XIVDB Links Broken

It appears the links to recipes/items are broken to XIVDB.

For example, upon clicking on Holy Rainbow Work Gloves, I am taken to http://xivdb.com/recipe/2749 which appears to be an incomplete URL. The complete URL is http://xivdb.com/item/11994/holy+rainbow+work+gloves.

feat: add filters for recipe search field

Filtering on the following properties of an item could be really good:

• ilvl
• required level
• worn by
• crafted by

refactor math computing to use only integer math

Issues like #40 are due to a float precision error, because of javascript's poor precision with floating numbers.

Using an integer-based logic would solve this.

Example implementation by Clorifex:

var needed = step.required - step.generated;

// Generated more than is needed, skip adding more ingredients.
if (needed <= 0)
    return step;

var cyield = step.craft.yield || 1;
var newAmountNeeded = Math.ceil(needed / cyield);
step.generated += newAmountNeeded * cyield;

Gils trades not handled

Gils are not handled as trades, they are in a vendors array:

"vendors": [
    1011201
],

Items in both recipes and pre-crafts are check together while only the recipe should be checked.

See https://www.reddit.com/r/ffxiv/comments/6u1jxw/collaborative_crafting_tool_ffxiv_teamcraft/dlpjp0g/

Bug: Inconsistent Progress and Totals With Recipes With Yields Of More Than One

Couldn't think of a better way to title that.
The total required mats for the specified end product is correct based on the yields. However when crafting an Infusion of Strength for example, one craft yields 3 potions, it should have used 1 Crescent Spring Water but it instead thinks 3 was used. The result is that with a goal of making 99 potions, the website will say all materials have been used after 33 potions have been made. After 33 strength potions 22 Parsley should have been used instead of 66, 11 spring water, and 11 salt crystal.

First list creation from recipes page is not creating list

When you create your first list with a fresh account, it doesn't work from recipes page and you have to go on the lists page to create the first one, after that it's working well.

searching for ingot with "crafted by BSM" filter returns ARM ingots too

That's probably because the item is the same, the fix has to be implemented in the post-search-request observable.

feat: ability to bookmark other's lists

It would be interesting to have a bookmark system, to "save" one's list in your account, in a specific page where you can see the lists you bookmarked.

Actually users have to bookmark the list using the browser, that's probably not enough.

Source: https://www.reddit.com/r/ffxiv/comments/6yfyg0/ffxiv_teamcraft_first_release/dmo6cpa/

Google login seems to be broken

I created an account earlier using the Register with Google button, however when i try to Log In with Google nothing really happens, the Login/Registration buttons on the left change to one Disconnect button for about a second then change back to the Login/Register buttons

refactor: change list amount input field listener for a debounce

The current input field to edit item amount in a list (in the /lists view) is really terrible in terms of UX, whenever you edit it, the listener is called and you loose the focus on the field, becoming really annoying.

Changing this for a debounce (like for recipes search field or item amount in /list/X/Y view) will greatly improve UX for this part of the website.

Issue with gazelleskin items

Steps to reproduce:

• Create a new list
• Try to add Gazelleskin item

It seems like it's drop-related, more investigation is needed.

character add sometimes buggy

Sometimes, character addition popup is laggy, adding a manual check button might be a solution, or increasing the debounceTIme but it may become too slow.

Combine aetherial reduction icons into 1 with all possible reduction possibilities listed as a tooltip

Search returns empty result with no message in some cases

Sometimes when you search for a recipe, it shows a blank result set with no message and you have to press a keyboard key once more to have an actual result.

It could come from the fact that xivdb is limiting to 5req/s to the search API, more investigation is needed.

feat: macro sharing support

It would be really good to have a way to give players some macros for crafts, based on criterias, players could create dynamically translated macros, for easy sharing and they could be shown as a tip for crafts, based on criterias (ex: macro for 70 1star crafts with 70 durability).

Configurable Recipe Links

I distain xivdb.com and because of that, I love the feature on ariyala that allows you to choose where the item links take you. I'm sure I'm not the only one who feels this way.

feat: add airship ventures support

feat: user authentication support

A user has to be able to have an authentication, it can be done using:

• Email & password
• Google Oauth
• Facebook Oauth

During the account creation, the user has to get his old lists (created from anonymous account) moved to the new account.

Bug: Unable to add recipes to list

I am unable to add most level 70 2 star recipe to any list. Steppe Tea is the only one that currently works for me. Jellied Compote and Persimmon Leaf Sushi also cannot be added. I had nearly all of them added to different lists a few days ago but haven't been able to add them since. No notification appears when making an attempt. It will create an empty list when trying to make a new list with one.

Thanks,

Add proper testing for easier contributions, integrated with a CI tool

character add sometimes get more than one char with good name

Example: https://xivsync.com/character/search?name=Blackphoenix%20Black

A fix could be to add a filter on the result array based on the name property to ensure we get the right one, as the api doesn't seem to apply filter properly.

feat: display trade icon based on the currency used

We could use a priority system, something like:

• gils: 20
• tomes: 15
• beast tribe currency: 10
• other: 1

and display the currency with the highest priority

Modal Missing Close Action

No way to cancel registration at all unless you refresh page or successfully enter correct details into the modal.

Need to add simple modal closing functionality.

Recipes with multiples not handled correctly

When setting it up to craft Gazelle Leather, I was making four. It should have recommended that I make two batches of three persimmon tannin to total six as each recipe of leather requires 1. It recommended I make four batches of three tannin, yielding ten extra.