ffmg / myoddweb.piger Goto Github PK

If you have an invalid code, (missing variable or invalid parms then piger dies).

import am
am.say( 121, 10, 50 ); # dies here because '121' should be a string,
exit(1);

We need to catch those errors and tell the user that the script is broken.

The install should gracefully

1. Stop Piger if it is running
2. Install the new version
3. Restart Piger if it was running, (in 1)

The install is missing the Visual C++ Redistributable for Visual Studio 2015

If inno setup is installed, then we should parse iss files.

F.

If we create a simple powershell script

  [void]($am.Say( "Hello!", 400, 10 ))

And move it to the __in folder, (so it is loaded at startup), the app freezes.

If there is an error during execute we should show an error message.

For example

am_execute( [[%SystemRoot%\System32\calcx.exe]], "", false);

the file calcx.exe does not exist, and the error should be reported.

HelperApi should have a 'last error' string and/or number so we can display the message.

Calling the "Hello Dolly" plugin is not random.
The same "quote" is given over and over again.

While the log commands are called nothing actually seems to get logged.

The files are not created and nothing is logged, (because no files are created).

The configuration path is hardcoded to CONF_FULLPATH, ("%appdata%\MyOddWeb\ActionMonitor_d\profile.xml"), but we should be able to overwrite the value using command line params.

The values are set in

BOOL CActionMonitorApp::InitInstance()

The namespace ::myodd::config uses the class ::myodd::config::Data, this is not as good as ::myodd::dynamic::Any

So we should just remove it and replace it.

We might need to add new functions like, is_int/is_float/is_string so we can save load/save the data properly.

We need to do a clean test on version of windows.

• [ ] Windows XP
  • [ ] Clean
  • [ ] With Python 2.x installed.
  • [ ] With Python 3.x installed.
• Windows 7 (Home basic x86)
  • Clean
  • With Python 2.x installed.
  • With Python 3.x installed.
• Windows 8
  • Clean
  • With Python 2.x installed.
  • With Python 3.x installed.
• Windows 10
  • Clean
  • With Python 2.x installed.
  • With Python 3.x installed.

Need scripts to lock/unlock drives.

• Discover bitlock drives
• Lock drive(s)
• Unlock drive(s)

The app should not be able to start more than once.
There is a mutex at the start of the app that should prevent that from happening.

The version of TinyXML that we are using in myodd::xml namespace is ancient, (2013 I think).

We need to start using the newer version, https://github.com/leethomason/tinyxml2

The issues we need to be aware of are

• We made some small changes in our code, ideally those changes should not be present.
• We have no tests so we cannot test if the new version fits our current requirements/use cases.

Rather than escaping the code,

am_execute( "c:\the\path\here.exe", "" )

we should use the lua literal string

am_execute( [[c:\the\path\here.exe]], "" )

see lua strings

It would be great to embed Go language in piger with a couple of sample commands.

@see https://medium.com/using-go-in-mobile-apps/using-go-in-mobile-apps-part-1-calling-go-functions-from-c-be1ecf7dfbc6#.21bbpnueq for some hint.

Hi, I just installed to try it, when I enter chrome or firefox or iexplore as a command, the url it opens is this one

file:///C:/Program%20Files/myoddweb/Piger/ActionMonitor.exe

Running piger-0.6.16.14.exe and I'm on Windows 7 64

Then I tried opening filezilla and I also get an error, I'm assuming that it's because "C:/Program%20Files/myoddweb/Piger/ActionMonitor.exe" is passed as a first argument to any program I open? Because if try to open filezilla.exe like this I get the same error.

We should control what environment variables can be re-loaded.

• TMP
• TEMP
• Path
• PathExt

Especially the first 2 as they could actually change the temp folder(s) and that could be an issue.

There are some issues with log files

• They are created/timestamped at start time, but if the pc runs for weeks/months the log file name is out of date, (making it hard to find).
• The folder itself is never pruned, we should be able to remove files older than xyz days.
• The file could grow to gigs in size, (maybe because of issue #1), this could be a problem. Maybe we should limit the file size to 10Mb and start a new file if need be.

Simply try to learn/unlearn a command, it will remain in the list.

learn calc
unlearn calc
unlearn calc

the second unlearn calc should not be in the list as it was removed.

We need to catch if the user is trying to use myodd/log and it has not been initialized.
But we mustn't kill the whole process.

Maybe just in debug as a heads up.

We should either set the value to true or create a new command.

learn ...

would be for non elevated commands

learn elevated ...

should be for an elevated command.

Sometimes it would be nice to have a message appear that is non blocking.

am_say( ... ) is currently blocking, it would be great to have a non blocking version.

The python code below does not seem to return a proper version number.

import am;
x = am.version();
am.say( str(x), 10, 10 );

When we move to python 3.10 we need to remove PyEval_AcquireLock as it is deprecated deprecated

There are a couple of issues with the exes

• We don;t know if the exe is elevated or now, when creating the action we should know if elevated or not.
• Can params passed to the exe(s)?
• AppPath module should be able to 'guess' if an app should be elevated or not.
• AppPath should know of certain apps and either not include them, (because they are a waste of time), or include required params.
  • For example browsers, we should look for certain values to pass/not pass.
  • Certain apps like RDC could be passed params, but they need very specific information.

If a user selected to install a certain plugin, for example "Hello Dolly", but then choose not to install it again for the next update, the install will not install it.

But that could be a problem:

• In case of breaking changes, (the API is still been worked on!)
• In case the user will not understand why the unselected plugin(s) still appear.
• How else can the users remove a plugin? (if not manually)

the default location for calc.exe is not %SystemRoot%\system32\calc.exe as we have it.
So the calc does not launch

We need to find a more robust way of launching calc.exe

We need to get rid of some windows specific functions, they give anoying errors/warnings and are just not needed at all.

• __time64_t
• _time64
• _localtime64_s

Those are not really needed, we just need the year/month/day

Add a mute/unmute command

• Powershell?
• Lua?
• Python?

Make the powershell one default?

When we call

local blah = "Some string";
am_execute( [[my.exe]], [[query "]] ... blah ...[["]], false );

And I am also not 100% sure what will happen if the string is un-escaped, (blah=""hello""), or something like that.

We need to execute *.cmd files.

They are very similar to *.bat, (one is 16bit and the other 32bit), but still needs its own active action to ensure it is picked up properly, (or derive one from the other)

See:
http://stackoverflow.com/questions/148968/windows-batch-files-bat-vs-cmd
http://itknowledgeexchange.techtarget.com/itanswers/how-to-run-cmd-files/

and

https://en.wikipedia.org/wiki/Batch_file

F.

When environment variables are updated we need to restart the app.
This is not ideal we need to update all the variables, (like %path% and so on), so the launched apps get the latest values.

Looks like they are not sharing the static values and need to be initialized somehow.

CF_DROP is not properly supported.

• We need to update the clipboard to read/write the data
• We need to update the clipboard to return those files, (currently only the explorer files are returned).

If you call the RemoveAction(...) helper function, it does not remove it from the list.

It would be nice to create a blank/templated solution for plugins.

• Select a Microsoft document, (like an outlook message)
• Select an image in that documents, (just select it).
• Select a piger command
• This will cause a crash...

We need to do a clean test on version of windows.

• Windows 7
  • Clean
  • With Python 2.x installed.
  • With Python 3.x installed.
• Windows 8
  • Clean
  • With Python 2.x installed.
  • With Python 3.x installed.
• Windows 10
  • Clean
  • With Python 2.x installed.
  • With Python 3.x installed.
• [ ] UseEmbedded Python disabled, (in config)
  • [ ] With Python 2.x installed.
  • [ ] With Python 3.x installed.
  • [ ] Python not installed on user machine, (should not break)

As the list of plugins will grow over time, we need to have a list of some sort, for example

• General
  • Plugin A
  • Plugin B
• Os specific
  • Plugin C
  • Plugin A
• Misc
  • Plugin A
  • Plugin B
  • Plugin C

We should be able to launch powershell scripts directly.

@see http://mrpowershell.blogspot.co.za/2013/10/how-to-cal-powershell-script-with-c.html for some interesting approach.

We need to elevate the script.

NB: This is the same a batch files, they are called directly.
A future usage would be to get the script to use an am module.

Add a perl virtual machine to piger

See some embedded sample

The following code causes piger to close.

import am
am.say( "Goodbye!", 100, 5 )
exit(1)

Piger should not close because of an exit(1) request in the code.

Put the following code in the __out folder.

import am
am.say( "Piger is shutting Down", 100, 5 )

This will cause a resource issue in

_PyTraceMalloc_Fini(); // pylifecycle.c

The same issue does not appear if you call the same command directly.

Log files are not created properly, (invalid name/location)

See, https://sourceforge.net/projects/pcre/files/

F.

• Select an excel document
• Select a large amount of rows, (a lot!)
• Launch a piger action and this could cause the entire system to seize up.

This is because of the way we allocate memory for the clipboard, if the memory is extremely large then we could lock up the system.

Ideally we would have 2 clipboard options

• Maximum memory size to allocate, (regardless of format, we will not burn too much memory).
• List of 'excluded' formats, (so all others are included by default)
• List of 'limited' formats, (so all others are excluded by default)

Add a python section to the config to prevent the default embedded python.

<python>
  <useembedded type="1">1</useembedded>
</python>

This is useful for special cases where developers have set their environments to use special modules and so on,

When we add a command that already exits using loader, the command is created but an error message is returned.

learn calc
learn calc

the second learn calc will return an error even when created/updated properly,

Make it easier to quickly tell the current version