ferrenaalexander / helloworld

assignment 5

Alexander Ferrena, PhD

Hello and welcome to my Github! My name is Alex, I'm a computational biologist at NYU Langone Health.

For more about me, including my CV / Resume, see my website.

Projects

• scDAPP, an end-to-end analysis pipeline for replicate-aware cross-group comparison of single cell transcriptomic data
• Einstein Montefiore Omics Club, a networking association at Albert Einstein College of Medicine and Montefiore for those with shared interest in omics technology

Publications

• Pubmed | Google Scholar

helloworld's Issues

Code Review

Hello! I enjoyed checking out your package.

1. Were you able to successfully clone and install their package? Yes!
2. Were you able to run their executable helloworld program? Yes!

When I typed helloworld.helloworld(bestmusic = "jazz"), I got the following response:
hello, world! and hello to you too, user!
Vaporwave is actually the best genre of music.
I'm out. Cheerio!

And when I typed:
helloworld.helloworld(bestmusic = "vaporware")
I got this message:
hello, world! and hello to you too, user!
You are correct. Vaporwave is indeed the best genre of music.
I'm out. Cheerio!

So that was pretty funny. :)

I ran the "polite" function too:
In [14]: helloworld.helloworld(polite = "nice to meet you, dude!")

I got this output:
hello, world! and hello to you too, user!
Vaporwave is actually the best genre of music.
Pleasure making your acquantaince, friend. Adieu!

So it worked overall. I think maybe it would be good to just have the one line "Pleasure making your acquantaince, friend. Adieu!" be the output rather than repeat the earlier lines. (Also, there's a small typo.)

When I ran the crabtime function, I also got the other lines about Vaporware and the greeting again:
hello, world! and hello to you too, user!
Vaporwave is actually the best genre of music.
351997 days since the Crab Nebula's supernova.
I'm out. Cheerio!

3. Did you their package code look clean and properly formatted so there were few or no linter errors? The linter doesn't necessarily like the tabs and spacing, but the code works.