Add `module` property in package.json about lit-redux-router

[jorgecasar]

Rollup also alert about this:

(!) `this` has been rewritten to `undefined`
https://rollupjs.org/guide/en/#error-this-is-undefined
node_modules/lit-redux-router/dist/route.js
47: }
48: 
49: var __decorate = this && this.__decorate || function (decorators, target, key, desc) {
                     ^
50:   var c = arguments.length,
51:       r = c < 3 ? target : desc === null ? desc = Object.getOwnPropertyDescriptor(target, key) : desc,

[fernandopasik]

Hi @jorgecasar! Thanks for opening this issue

I've added the module attribute pointing to the main typescript file.

"module": "src/lit-redux-router.ts"

[fernandopasik]

Rollup also alert about this:

(!) `this` has been rewritten to `undefined`
https://rollupjs.org/guide/en/#error-this-is-undefined
node_modules/lit-redux-router/dist/route.js
47: }
48: 
49: var __decorate = this && this.__decorate || function (decorators, target, key, desc) {
                     ^
50:   var c = arguments.length,
51:       r = c < 3 ? target : desc === null ? desc = Object.getOwnPropertyDescriptor(target, key) : desc,

please try again with the new version and I'll re-open this issue

[fernandopasik]

fixed in https://github.com/fernandopasik/lit-redux-router/releases/tag/v0.9.6

[jorgecasar]

Typescript is not a JavaScript I should use Babel to parse your library. You have to generate 2 distributions. Es modules and commonjs. Really with esm is enough because litElement is only distributed as module.

[fernandopasik]

Then I think what I should do, it's just point module to dist/lit-redux-router.js as that is ES modules as well. What do you think?

[jorgecasar]

Yes, it should work. In the other hand we have the roll-up issue you commented

[fernandopasik]

ok, I've fixed the module property and published a new version.

Could you please provide more details on how to reproduce the issue with rollup?

[jorgecasar]

I guess it's a tsconfig because running npm run build there are 2 warnings:

dist/lit-redux-router.js → dist/lit-redux-router.min.js...
(!) The 'this' keyword is equivalent to 'undefined' at the top level of an ES module, and has been rewritten
(!) The 'this' keyword is equivalent to 'undefined' at the top level of an ES module, and has been rewritten

[fernandopasik]

I noticed that, and the transpiled code that you posted before. Did this bring you any problem?

[fernandopasik]

I think it must be to avoid conflicts with an existing polyfill declaration or something

[fernandopasik]

https://rollupjs.org/guide/en/#error-this-is-undefined

I've added ignores for known warnings in the rollup config. If this causes any problems we can reopen this issue