Coder Social home page Coder Social logo

Comments (8)

stale avatar stale commented on June 15, 2024 1

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from lit-redux-router.

fernandopasik avatar fernandopasik commented on June 15, 2024 1

Sorry for the delay on this, looking at your point you are right the route element should append it all in the light dom, I'll change this. Thanks for raising it.

from lit-redux-router.

fernandopasik avatar fernandopasik commented on June 15, 2024 1

Analyzing this a bit further I see a complication with a use where you provide the route content through the slot , since that is not available in light dom.

I think the only way to fulfill this feature without loosing other will be with an option in the lit-route element

from lit-redux-router.

stale avatar stale commented on June 15, 2024 1

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from lit-redux-router.

thescientist13 avatar thescientist13 commented on June 15, 2024

Just commenting to keep this alive a bit longer. 🤞

from lit-redux-router.

thescientist13 avatar thescientist13 commented on June 15, 2024

Yeah, I think it would make sense to make this an opt-in feature, which by default I think should work as it does now, to render into Shadow DOM, and continue to follow natural behavior of WCs and their compositional properties, like with <slot> as you say. I think in general, having encapsulation at the route level is pretty nice.

For users like myself who have a need to break out of that model (and also maybe with a link to a resource that explains what you lose when turning off Shadow DOM) would be a good way to get the best of both, and would be a backwards compatible change. 💯

from lit-redux-router.

stale avatar stale commented on June 15, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from lit-redux-router.

stale avatar stale commented on June 15, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from lit-redux-router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.