Comments (8)
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
from lit-redux-router.
Sorry for the delay on this, looking at your point you are right the route element should append it all in the light dom, I'll change this. Thanks for raising it.
from lit-redux-router.
Analyzing this a bit further I see a complication with a use where you provide the route content through the slot
, since that is not available in light dom.
I think the only way to fulfill this feature without loosing other will be with an option in the lit-route
element
from lit-redux-router.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
from lit-redux-router.
Just commenting to keep this alive a bit longer. 🤞
from lit-redux-router.
Yeah, I think it would make sense to make this an opt-in feature, which by default I think should work as it does now, to render into Shadow DOM, and continue to follow natural behavior of WCs and their compositional properties, like with <slot>
as you say. I think in general, having encapsulation at the route level is pretty nice.
For users like myself who have a need to break out of that model (and also maybe with a link to a resource that explains what you lose when turning off Shadow DOM) would be a good way to get the best of both, and would be a backwards compatible change. 💯
from lit-redux-router.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
from lit-redux-router.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
from lit-redux-router.
Related Issues (20)
- XSS vulnerability when using path params
- Ability to conditionally pre-redirect HOT 3
- Update Documentation to show store setup HOT 2
- route not working. HOT 1
- path routing 404 on client side HOT 3
- JS error in Edge v44 HOT 4
- allow path to assume base href HOT 3
- Suggestion - enable `scrollDisable` by default HOT 3
- how to get query params HOT 2
- Component reloads on every state change HOT 5
- Imports should specify the file extension HOT 11
- Lazy Loaded components are never rendered
- Usage with redux-toolkit? HOT 3
- lit-route lit-plugin typing HOT 4
- Upgrade to latest version / distribution of `Lit@2` HOT 9
- The demo folder is also published to NPM which causes issues when building HOT 1
- Allow the use of sub-routers HOT 1
- Add authentication property HOT 2
- Using subroutes inside of components (with shadowRoot) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lit-redux-router.