fergusgriggs / fegaria Goto Github PK

I'm running the game on Python2
If it's intended to run on Python3 only, please state it in the readme.

line 1331: list indices must be integers, not float
I used int() around the indices.
This goes for most of the times you use the "mapData" matrix.
You did it too in line 508

line 1385: range() integer end argument expected, got float
"heartNum" is saved as a "ciel" of something: this doesn't make it int, I guess.
So again I used int() to fix

line 190
super().__init__(pos,"bird",vel)
TypeError: super() takes at least 1 argument (0 given)
I'm new to Python, but I think you need to write:
NPC.__init__(self, pos, "bird", vel)

I did a fix to these, if needed I can make a pull request.

The same problem with indices goes for some image loading:
img=images[240+math.floor((self.blocks[i][j].maxintegrity-self.blocks[i][j].integrity)/self.blocks[i][j].maxintegrity*9)]
math.floor doesn't return an int, but a float, so I'm still getting error for these.

game will get stuck on
Generating Terrain

Firstly Physics is hard..

I think the player jitter is coming from your grounded logic, and the subsequent corrections to player pos in the collision loops.

I tinkered with it for a while, if you stop applying gravity once you're rested on a surface you can keep the player jitter free, however you have to find the right place in your game loop to change the grounded to false if the player steps off a surface or jumps. (Jump is the easy one out of the two)

I'm happy to help!

I found your game listed on https://www.pygame.org/news and popped in to check it out earlier.

Played for a while, pressed all down and low row key, when started to press keys of high alphabetic row from left to right, game crashed on "U" key

Traceback (most recent call last):
  File "fegararia v0.05.py", line 2187, in <module>
    p.kill()
  File "fegararia v0.05.py", line 1174, in kill
    self.changeItem("copper coin",["coin"],-copper)
TypeError: changeItem() takes 3 positional arguments but 4 were given

Hin thanks for sharing this, interesting to learn from!

I cloned the repository and are trying to run the game using both python2 and 3; output is:

Spawning stone...
Traceback (most recent call last):
File "fegararia v0.05.py", line 1962, in
CAM.Map.generateTerrain(0)
File "fegararia v0.05.py", line 454, in generateTerrain
ore(1,6,None,(425,500),(6,CHUNKNUMX*CHUNKSIZE-6),1)
File "fegararia v0.05.py", line 556, in ore
ore(val,size-1,(pos[0]+1,pos[1]),None,None,back)
File "fegararia v0.05.py", line 556, in ore
ore(val,size-1,(pos[0]+1,pos[1]),None,None,back)
File "fegararia v0.05.py", line 556, in ore
ore(val,size-1,(pos[0]+1,pos[1]),None,None,back)
File "fegararia v0.05.py", line 558, in ore
ore(val,size-1,(pos[0],pos[1]-1),None,None,back)
File "fegararia v0.05.py", line 556, in ore
ore(val,size-1,(pos[0]+1,pos[1]),None,None,back)
File "fegararia v0.05.py", line 556, in ore
ore(val,size-1,(pos[0]+1,pos[1]),None,None,back)
File "fegararia v0.05.py", line 556, in ore
ore(val,size-1,(pos[0]+1,pos[1]),None,None,back)
File "fegararia v0.05.py", line 549, in ore
if mapData[pos[1]][pos[0]][0]>0:
IndexError: list index out of range

The game is really nice, but it needs to be optimized
looking forward for updates