felmoltor / keepnote_import_nmap

Plugin for keepnote to import a XML nmap file

Hi there 👋

• 🔭 I'm Felipe Molina, currently working at SensePost group of Orange Cyberdefense 🟧.
• ➕ Many of my personal repos are from the past, but some others are recent and can be found in the SensePost github.
• ⚡ Fun fact about me: I am not an AI!
• 📫 My Mastodon profile: Mastodon

keepnote_import_nmap's Issues

osclass is no longer a child of osmatch in nmap output

The plugin throws an error on line 259

                osfamily = osmatch.getElementsByTagName("osclass")[0].getAttribute("family")
                osvendor = osmatch.getElementsByTagName("osclass")[0].getAttribute("vendor")
                ostype = osmatch.getElementsByTagName("osclass")[0].getAttribute("type")

This is due to osclass no longer being a child of osmatch i.e. from a recent nmap xml output

<os><portused state="open" proto="tcp" portid="XXX" /> 
<osclass type="general purpose" vendor="OpenBSD" osfamily="OpenBSD" osgen="4.X" accuracy="85" />
<osmatch name="OpenBSD 4.3" accuracy="85" line="30610"/>
<osmatch name="OpenBSD 4.0" accuracy="85" line="30351"/>
</os>

Locally I have changed this to

                osfamily = hostnode.getElementsByTagName("os")[0].getElementsByTagName("osclass")[0].getAttribute("family")
                osvendor = hostnode.getElementsByTagName("os")[0].getElementsByTagName("osclass")[0].getAttribute("vendor")
                ostype   = hostnode.getElementsByTagName("os")[0].getElementsByTagName("osclass")[0].getAttribute("type")

To allow this to work; however I am unsure of the intent in the code at first glance is intended to append the multple match results or take the first osclass in each case? once clarified I'll create a fork (if needed) and submit a pull request.