felixkratz / jankyborders Goto Github PK

Hello,

I'm attempting to package JankyBorders for Nix but I'm running into a compile error as below:

this derivation will be built:
  /nix/store/h39fn5v0sn0py2r43j20wr6nqxvc94f6-JankyBorders-1.3.0.drv
building '/nix/store/h39fn5v0sn0py2r43j20wr6nqxvc94f6-JankyBorders-1.3.0.drv'...
unpacking sources
unpacking source archive /nix/store/a7ri5w5wvr427xgwlyh7ax2g41gq01s4-source
source root is source
patching sources
updateAutotoolsGnuConfigScriptsPhase
configuring
no configure script, doing nothing
building
build flags: SHELL=/nix/store/x1xxsh1gp6y389hyl40a0i74dkxiprl7-bash-5.2-p15/bin/bash
mkdir bin
clang -std=c99 -O3 -g src/main.c src/mach.c src/hashtable.c src/events.c src/windows.c src/border.c  -o bin/borders -framework AppKit -F/System/Library/PrivateFrameworks/ -framework SkyLight
Undefined symbols for architecture arm64:
  "_SLSWindowManagementBridgeSetDelegate", referenced from:
      _main in main-07b876.o
ld: symbol(s) not found for architecture arm64
clang-16: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [makefile:5: all] Error 1
error: builder for '/nix/store/h39fn5v0sn0py2r43j20wr6nqxvc94f6-JankyBorders-1.3.0.drv' failed with exit code 2;
       last 10 log lines:
       > building
       > build flags: SHELL=/nix/store/x1xxsh1gp6y389hyl40a0i74dkxiprl7-bash-5.2-p15/bin/bash
       > mkdir bin
       > clang -std=c99 -O3 -g src/main.c src/mach.c src/hashtable.c src/events.c src/windows.c src/border.c  -o bin/borders -framework AppKit -F/System/Library/PrivateFrameworks/ -framework SkyLight
       > Undefined symbols for architecture arm64:
       >   "_SLSWindowManagementBridgeSetDelegate", referenced from:
       >       _main in main-07b876.o
       > ld: symbol(s) not found for architecture arm64
       > clang-16: error: linker command failed with exit code 1 (use -v to see invocation)
       > make: *** [makefile:5: all] Error 1
       For full logs, run 'nix log /nix/store/h39fn5v0sn0py2r43j20wr6nqxvc94f6-JankyBorders-1.3.0.drv'.

I am able to build this on my host with the Makefile outside of Nix without issue. I'm curious if you have any suggestion on things to troubleshoot?

I am on macOS Sonoma and using Stage Manager on macOS Sonoma, and I just installed JankyBorders earlier today. I have noticed that when a window is "minimized" (in the column on the left), the border is still in the space where the active window is. I will comment a screenshot once I'm back on my MacBook.

Source: https://www.reddit.com/r/unixporn/comments/w9s22b/hyprland_noble/

Source: https://www.reddit.com/r/unixporn/comments/zqyrqi/hyprland_glowy/?rdt=34170

(Bright spots are actually animated and moves around the border)

Source: https://www.reddit.com/r/unixporn/comments/17kx85t/hyprland_tokyo_night_nixos/?rdt=55754

--

I think this could look good when customized properly. Probably more useful for the active window than inactive ones. The static effect could likely be implemented by tweaking the border window shadow properties.

Hi,

Always loved colored window borders since started using yabai and was extremely upset after it was removed. Found this project and was happy that it will bring back to life my one of the most loved features.

Tried installing with brew and get: borders: An unsatisfied requirement failed this build.

Then tried dowloading a source code and building by myself and everything worked without any issues.

Since I don't see any issues running this project on Ventura is it posible to make installation possible via brew without OS restrictions or at least lower the limitation to Ventura?

Thanks in advance :)

I use Arc browser, which comes with a built in PiP window whenever you swap tabs on a running video feed.

When this feature is used with Borders, the border seem to wrap around much larger window than the PiP window itself, creating a visual glitch.

This used to cause issues with Yabai as well, but in v6.0.3 the issue was fixed (Yabai #1622)

The ideal behaviour is for Borders to ignore these windows natively similar to Yabai, alternatively offering a config based exclusion.

Note: in my set up Borders config is in the yabairc
borders active_color=0xffe1e3e4 inactive_color=0xff494d64 width=5.0 style=round &

🙏

I have experienced that the border will appear on the "correct" window but on the wrong display. I have noticed that from time to time, the border will appear on the wrong display.
Say I have two displays with two open windows each in a vertical split view. Display A, has A.l (left) and A.r (right) as windows, and display B, has B.l and B.r. Sometimes I experience that if B.l have focus A.l will have drawn border and vice versa.

These are some TODOs that are up for grabs:

Done

• Fix some quirks with certain window focus events not leading to the window border being highlighted/dehighlighted (e.g. if no window is focused (Finder is the front app in this case))
  Done 79aeed0
• Add borders to all windows that where created before the borders was launched
  Done #5
• Add a lock file to make it impossible to launch the process twice
  Done #12
• Add a client-server communication to make changes to the border properties during runtime possible (i.e. like yabai or sketchybar)
  Done fad2f55
• Windows coming back from native fullscreen have no border
  Done 1701aee
• When a window is minimized on startup of borders, is does not receive a border when it is unminimized
  Done 1701aee

As all of these todos seem to be complete I will release an update later which should be stable for now and not contain any more quirks or bugs.

If you choose to work on any one of them, please create a PR to this repo such that all can benefit from your improvements.

Idk if I am just dumb but I was trying for a couple of days on and off and could not figure out why my bordersrc file was not working until I found out it must be executable. Is that obvious? Regardless, simply having this as a searchable issue should hopefully help someone. :)

Maybe add a little one-liner to readme? starting the service does not say anything...

The border switches to the active state only after clicking on the window with the inactive border, instead of following active window.

Whenever I am changing spaces, but most noticeably when swiping between spaces (it's just to fast when using keybinds) JB draws border for all windows regardless of display during the switching process.
Normally looks like:

But specifically while changing spaces, it temporarily looks like:

It's especially evident when transitioning to/from an empty desktop or one with transparent windows, and there is another desktop split by yabai for two windows:

(The center line should not be there)

Any idea why?

Can we exclude certain apps while drawing the border? Yabai had that option and it is crucial for some apps to function in my setup.

For e.g. slack has a had time with huddle when border is on

First of all, thank you for trying to fill the gap left by Yabai's border removal.

I added the following to my .yabairc:

borders active_color=0xffffffff inactive_color=0xff494d64 width=5.0 2>/dev/null 1>&2 &

I noticed something with windows created before yabai started.

The main window on the left was already created, and used to start yabai. Then once it was running, I created the windows on the right. When I use the command opt+k/j/l to move between windows, the two new windows seem to have the border correctly, but when I refocus on the older existing window, the border doesn't get added.

As you can see from the image above, the window on the left has the MacOS drop shadow, signifying that it is currently focused, but the white border is on the bottom right window.

Hi, i'm trying to install JankyBorders from brew, but after brew install FelixKratz/formulae/borders this is the output:
Warning: No available formula or cask with the name "felixkratz/formulae/borders". Did you mean felixkratz/formulae/svim, felixkratz/formulae/fyabai or felixkratz/formulae/fnnn?
I will clone the repository to compile it manually, I just created this issues to report the problem

So I noticed this weird bug that I can reproduce reliably, where a border that is initialized for an existing window on a different space upon launch will for some reason be moved back to the first/active space upon a window focus change event, as long as no other events have occurred. Edit: On commit 96534dd

Basically, have two windows open on the active space, and have one window open on any alternate space.
Start borders and notice that you only get two borders drawn as expected. If you now switch focus to the other window in the same space, it suddenly drags the border belonging to the alternate space window and draws it on the active space.

If you create a new window first, and then focus a window, the bug does not occur.
I also verified that the border is actually moved properly after it is created by commenting out the responsible code in the add_borders_for_existing_windows function. When that move-call is removed, the border is drawn on the active space all the time (which one would expect).

Hi @FelixKratz

Thank you for all your work. It really is nice to have these features due to your hard work.

I have been experiencing slowdown issues while using JankyBorders and after uninstalling it last night my M2 Pro machine is running fast again. It seems like the same issue as in this issue, hence why borders were removed from Yabai v6:

koekeishiya/yabai#1775

Have you been experiencing this issue and is there a solution to it?

Thanks

When using focus_follows_mouse autofocus in yabai and trying to switch between two windows of the same application (ex Firefox, Alacritty) the border doesn't change by only moving the cursor, unless a click is performed on the focused window.

The bug doesn't happen when changing the focus between two windows that belong to different instances of the same application, for instance by opening two Alacritty windows with open -na Alacritty

It enhances the user experience [...] without relying on the accessibility API

Could you add a little sentence-blurb here describing how the software does achieve its functionality? 😄

ty!

I'm trying to add "IntelliJ IDEA" to the blacklist but having no luck since I'm guessing the spaces are the problem. When I add "Safari" or "iTerm2" it works just as expected and prevents them from getting borders.

I tried using single quotes, as well as escaping the spaces with \ (ex: "blacklist="IntelliJ\ IDEA") but that didn't seem to work either.

Am I using it incorrectly?

bordersrc file 👇

#!/bin/bash

options=(
    style=round
    width=5.0
    hidpi=on
    active_color=0xffc678dd
    inactive_color=0xff414550
    blacklist="'IntelliJ IDEA'"
)

borders "${options[@]}"

Note:
I looked into the code and saw the window_in_list() function looks to be the one checking this by calling proc_name() but I'm not familiar with Objective-C to know how that works or how to test this

static bool window_in_list(struct table* list, pid_t pid) {
  static char pid_name_buffer[PROC_PIDPATHINFO_MAXSIZE];
  proc_name(pid, pid_name_buffer, sizeof(pid_name_buffer));
  if (table_find(list, pid_name_buffer)) return true;
  return false;
}

Hello,
I was wondering if you could be interested in a feature that allows to specify the border color for different type of windows:

• active
• floating
• fullscreen

When the window is focused, the border can change depending on the window type, with a config like this one:

options=(
    active_color="0xAABBCCDDEEFF"
    float_color="0xAABBCCDDEEFF"
    fullscreen_color="0xAABBCCDDEEFF"
)

borders "${options[@]}"

What do you think?

ctrl + alt + shift - n : yabai -m space --create && \
                  index="$(yabai -m query --spaces --display | jq 'map(select(.))[-1].index')" && \
                  yabai -m window --space "${index}" && \
                  yabai -m space --focus "${index}" 

I have this in my skhd. After this command, the border for the given window stop updating (size and color)

The make command and brew install fails. I'm on a M1 Macbook Pro.

╰─ make
clang -std=c99 -O3 -g src/main.c src/mach.c src/hashtable.c src/events.c src/windows.c src/border.c  -o bin/borders -framework AppKit -F/System/Library/PrivateFrameworks/ -framework SkyLight
In file included from src/main.c:2:
In file included from src/events.h:2:
src/extern.h:1:10: fatal error: 'CoreGraphics/CoreGraphics.h' file not found
#include <CoreGraphics/CoreGraphics.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
src/mach.c:1:10: fatal error: 'bootstrap.h' file not found
#include <bootstrap.h>
         ^~~~~~~~~~~~~
1 error generated.
src/hashtable.c:2:10: fatal error: 'stdlib.h' file not found
#include <stdlib.h>
         ^~~~~~~~~~
1 error generated.
In file included from src/events.c:1:
In file included from src/events.h:2:
src/extern.h:1:10: fatal error: 'CoreGraphics/CoreGraphics.h' file not found
#include <CoreGraphics/CoreGraphics.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
In file included from src/windows.c:1:
src/windows.h:2:10: fatal error: 'stdlib.h' file not found
#include <stdlib.h>
         ^~~~~~~~~~
1 error generated.
In file included from src/border.c:1:
In file included from src/border.h:2:
In file included from src/helpers.h:1:
src/extern.h:1:10: fatal error: 'CoreGraphics/CoreGraphics.h' file not found
#include <CoreGraphics/CoreGraphics.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make: *** [all] Error 1

Hi,

Thanks for the excellent package. Is there a way to disable borders when there is only a single window active?

I don't know if this is easily added, but a way to query the current configuration (as a text dump) would be nice. E.g., I am currently writing a program which could be used to interactively change the borders configuration, such as + / - the width. But there is no good way to query the current width in order to write back a new width.

I'd like to start by thanking you for this software. Really appreciate it.

While running JankyBorders, I noticed that some windows from the JetBrains suite are getting a border when ideally I think they would be ignored.

I cloned the codebase and searched around and found your window_suitable function. I'm really curious where you found documentation about these tags. I'd like to update the function to somehow ignore windows that are more "popup-esque" but I could not find any information about these tags on the internet.

I'd be happy to make the change myself if you could shed some light on these tags. If you're unable to provide information, I'll take some time to debug the attributes myself to see if there's any obvious flag that marks something as a popup window.

Here's a screenshot for reference:

The "documentation" window on the right is technically focused at the time of taking this picture, but the border changing as the autocomplete window pops up and disappears while I'm typing can be quite jarring.

after last upgrade, old windows still dont have borders

Is it possible to make JankyBorders not only draw borders around a window but also filling the rectangle space beneath it?

This enhancement would enable the option to apply a tint to the translucent parts of an active window, providing a more visually appealing (to some) alternative to the current wallpaper 'bleed-through' effect

Add an option to customize the opacity of the border so that the "strength" of the colour can be modified.

In an older project Honer, there was an option to modify the opacity of the drawn window.

The project is implemented in obj-c, but still for the sake of ease, I have attached it here

https://github.com/puffnfresh/Honer.app/blob/090c5a27a13b3aab4ed9505e1dfd963862fb3e1d/Honer/OverlayWindow.m#L23

#import "OverlayWindow.h"

@implementation OverlayWindow

- (id)initWithContentRect:(NSRect)contentRect styleMask:(NSUInteger)style backing:(NSBackingStoreType)bufferingType defer:(BOOL)flag
{
    self = [super initWithContentRect:NSZeroRect styleMask:NSBorderlessWindowMask backing:bufferingType defer:flag];
    
    if ( self ) {
        [self setOpaque:NO];
        [self setBackgroundColor:[NSColor clearColor]];
        [self setLevel:NSPopUpMenuWindowLevel];
        [self setIgnoresMouseEvents:YES];

        [self updateAlpha:nil];
    }
    
    return self;
}

- (IBAction)updateAlpha:(id)sender
{
    NSInteger transparency = [[NSUserDefaults standardUserDefaults] doubleForKey:@"transparency"];
    CGFloat alpha = 1.0 - (transparency * 0.1);
    [self setAlphaValue:alpha];

    [self orderFront:sender];
}

- (void)awakeFromNib
{
}

@end

In my yabairc, i have the following:

yabai -m config focus_follows_mouse autofocus

So when I move my mouse onto a new window, it will focus that window. The border will not switch to that focused window unless I click on it after moving the mouse.

Borders at the end of my yabairc:

borders active_color=0xffcba6f7 inactive_color=0xff1e1e2e width=5.0 &

See attached screenshot, the left window is where I had moved my mouse, and the right window is showing the border

Hi,

I have noticed that the borders are a bit "blurry". I think there was an option in yabai when it had borders integrated that allowed us to select more high resolution rendering.

I have attached an image below that shows what I'm talking about.

Best regards.

Hello,
I am not sure if this is by design or not :)

I use yabai with focus_follows_mouse autofocus and if I have 2 windows in the same space and move the mouse from the active one to other, the border remain on the first window, while the focus changes. The same does not happen of course if I use focus_follows_mouse autoraise.

Would you be open to enable this functionality (I am not even sure its possible)?

I'm not sure if this is in scope for this project, but I'd love to see square borders akin to older versions of yabai, cxa's yabai fork and tiling WMs on Linux.

I don't know if this is a problem from Zoom or borders, just bringing this up to see if there are some solutions.

Very excited to have come across JankyBorders. However, on my M1 Pro Mac running 14.4 Beta (23E5180j), borders doesn't do anything. No error message, no complains, but also no borders. Nothing in the brew service logs either.

Just installed JankyBorders and noticed that the border around safari browser disappears as soon as I hover a link an a website.
Maybe this is because safari creates some kind of window for displaying the link target url in the bottom left corner?

On the latest version (and older ones as well), I noticed that according to btop, JankyBorders consumes almost 300MB of RAM, more than double what Emacs is using, and only less than Wezterm and Firefox. Is there anything inherent about the design of JB that results in such high memory consumption, or is this some sort of bug?

Hey there,
thanks for making all of these great programs and being so cool about feature request and bugfixes! Would it be possible to get double borders where the colours and sizes are adjustable independently from one another? I'd love to get something like this or this on macOS!

I got the following when trying to install via brew on an M1 MBPro on macOS Ventura 13.6.1:

$ brew install borders

borders: This software does not run on macOS versions older than Sonoma.
Error: borders: An unsatisfied requirement failed this build.

So I built the binary manually and it works completely fine. Posting so requirements for the brew formulae are relaxed, at least for Ventura which is quite recent.

Also, this works very well, I was missing borders from yabai. Thank you!

Firstly, thank you for taking the initiative in creating these kinds of applications.

I have some old border code laying around that uses most of the private events that you do in this project, and I noticed a fair bit of difference in the delay when moving a window around the screen. I've attached two gifs; the first is my throwaway proof of concept and the other is commit 110b01c

old poc:

this project:

I haven't really looked at the code in detail, so can't really tell why there is that much of a difference.

My old throwaway project also uses SLSRegisterNotifyProc(global_handler, 806, NULL); to respond to window move events to re-align the border.

I would love to be able to define in the config file a color for both light and dark mode, and that it would switch automatically based on that whenever system color scheme switch.

Example

active_color_light
active_color_dark
inactive_color_light
inactive_color_dark

Thanks !

Is there a way to configure the binary via file?
If i want to start it via brew services, i don't know how to pass configuration to the binary.

Of if this is possible, maybe you could says something about it in the readme?

Cheers
Felix

First off, thanks so much for taking on this project.

Please let me know what additional details would be useful to troubleshoot. I'm running on an Intel Mac, Sonoma 14.1 with SIP enabled. borders immediately crashes/aborts on start.

The only message I see is:

borders active_color=0xffe1e3e4 inactive_color=0xff494d64 width=5.0
[1]    58275 abort      borders active_color=0xffe1e3e4 inactive_color=0xff494d64 width=5.0

Thank you very much for this plugin, I see it's so cool but I'm facing some issues, can you please check it?

After enable for yabai followed by the command in the docs:
active_color=0xffe1e3e4 inactive_color=0xff494d64 width=5.0 2>/dev/null 1>&2 &

I do not know how to set to another color, try to set again like the command below but it not work:
active_color=0xffe1e3e4 inactive_color=0xff494d64 width=5.0 2>/dev/null 1>&2 &

Also if I want to disable it I just don't know how to do it event running the command: brew uninstall borders
Can you please update the README.md also the docs for the man command, thank you!

The MacOS shadow is appearing above the border which results in a much darker border color. Is there a way to force the border to appear above the shadow?

I'd love to disable the shadows with Yabai, but I cannot disable SIP on my computer.

I was wondering if there is an interest in having an "invert" of the blacklist.
For example, by default, borders will not be drawn for any application, and users will have to opt in to have borders drawn individually.

Thank you for this great piece of software @FelixKratz!

Hi, thanks for the work on this project. I started my own borders tool since yabai dropped the feature but this one is far superior.

One thing I miss from my own tool, that I'd like to request is to have an option to allow borders render on top of the application. This is great for square borders as with a slightly thicker border you can have the illusion of square windows.

Here's an old screenshot that demonstrates what I mean:

For some reason, the inactive border color of chromium based browsers differs from other windows. More clearly, it looks like the alpha channel is ignored.

Hi Felix, thanks for making JankyBorders. I was curious if you'd be interested in looking into adding the option of gradient borders, e.g., top right corner is yellow and transitions to green at bottom left corner, or something along those lines.

If you believe that is outside the scope of JankyBorders, I can try to implement it myself (following this), though I would need to familiarize myself with the codebase.

I have disabled shadows in Yabai, but the JankyBorders window still has shadows.