fbeen / uniqueslugbundle Goto Github PK

With this you could make sure that eg. PR's will pass all the tests - and then if you also use some code coverage stats you could track those too - so eg. if PR is made and tests passes but code coverage goes down - that is failure, because that PR didn't contain necessary tests to cover those new stuff.

I'm seeing eg.

if($this->existSlug($oldSlug, $results))
{
    return $oldSlug;
}

So what about following - https://symfony.com/doc/current/contributing/code/standards.html ?

Have thinked using eg. tools like:

• phpstan
• psalm

Hmm, so what is the LICENSE of this bundle?

Seems like current tests that this bundle contains has nothing to do with bundle itself.

You should write some tests for your bundle logic.

The README indicates that the make:slug command is used. It is not clear what it does:

• Is this step required?
• Does this command add the annotation?
• Is the command able to create a new field?

Looks like the current version is not compatible with Symfony 3.4.*

I try to use the last version and I'm getting this error

Uncaught Symfony\Component\Debug\Exception\UndefinedMethodException: Attempted to call an und
  efined method named "getRootNode" of class "Symfony\Component\Config\Definition\Builder\TreeBuilder"

when I try to change the version to 1.2 according to the documentation but I'm getting another error.

Any solution for that?

https://help.github.com/en/articles/about-code-owners

Hi
I am trying to run this in a script but apparently, the "yes" word is not passed to command, or if it is passed the command does not do anything:
yes yes | app/console fbeen:generate:slugs --em=blog BloggerBlogBundle:Product --env=vlad
however if I run it with
app/console fbeen:generate:slugs --em=blog BloggerBlogBundle:Product --env=vlad
and answer yes (enter) the slugs are generated

Within OS projects/libraries there is generally some contributing guide that people could follow when making eg. PR's - this project is currently missing that one.

According to composer.json this bundle requires at least PHP version 7.0.8 - so what about using proper return types and maybe even strict type?

http://php.net/manual/en/migration70.new-features.php

https://packagist.org/packages/fbeen/uniqueslugbundle#V2.2
https://github.com/Fbeen/UniqueSlugBundle/tree/V2.2

Implementation in tag V2.2 uses features from PHP not compatible with minimum version 7.0.8 declared in composer.json

https://github.com/Fbeen/UniqueSlugBundle/blob/V2.2/composer.json#L20

Incompatible features:

• void return type declaration
• object argument type declaration

Can you create a support branch for fixing issues in version 2.2?? I will contribute with the necessary changes to that branch so you can create a tag V2.2.1.