fayaz07 / hackernews Goto Github PK

Android app built with modern android architecture components, consuming HackerNews API

Home Page: https://hacker-news.firebaseio.com/v0/

License: MIT License

Kotlin 100.00%

toml-config splash-screen-android viewbinding viewmodel livedata navigation-architecture-component fragments dagger2 hilt dependency

hackernews's People

Stargazers

Watchers

Forkers

codehunterdev fayaz-tw

hackernews's Issues

throw exception if apiBaseUrl and version are not defined in local.properties

should be able to bookmark news articles

show user details, probably in story detailed screen as bottom sheets

finish story detail screen

restructure code

try to structure as clean-code-architecture

store ids by type in local database

store ids for show and other types in local database, a new table
for every id add timestamp (set timestamp value to when we fetched the data from internet)
while fetching ids, fetch from local database and merge both of them
if id already exists in local database, don't replace it with new one

should be able to open via the link - deeplinks

there should be a minimum time gap before requesting for data

should be able to send it to contacts

use content providers

change font to Source Sans Pro

https://fonts.google.com/specimen/Source+Sans+Pro

show comments for the post, probably in story detailed screen as bottom sheets

catching exceptions from retrofit

stories local sources tests

add gh action to build apk and upload to playstore

app crash

   Process: com.mohammadfayaz.news, PID: 6965
    java.lang.IllegalArgumentException: fromIndex(34) > toIndex(33)
        at java.util.ArrayList.subListRangeCheck(ArrayList.java:1018)
        at java.util.ArrayList.subList(ArrayList.java:1008)
        at com.mohammadfayaz.hn.domain.paging.StoryPagingSource$load$2.invokeSuspend(StoryPagingSource.kt:40)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
        at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:571)
        at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:750)
        at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:678)
        at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:665)