farling42 / fvtt-inline-linktext

Allows @inlineDocument references in Foundry descriptions

Welcome

fvtt-inline-linktext's Issues

Example

Hi!

Can you provide a noob friendly example?

Thank you!

V10: Support links to pages and sections within pages

V10 added the ability to link to a section within a page of a journal entry.

The inline should take the next paragraph/sentence after the header to which the link is pointing.

Or "whole document is selected", maybe only that one section should be included?

• Optionally with all sub-sections of that section (e.g. if pointer is to H2, then include all H3/H4/etc. up to the next H2)

Incompatible with systems/modules that override the class of actors, items, etc (e.g. PF2E)

When trying to use:

@inlineActor[mcnoyziJ3Je4nVoU]{test}

I got this bug:

The issue stems from the fact that the pathfinder 2e actor class is CharacterPF2E and not Actor.

I believe this could be solved by refactoring the code, so that instead of converting the doc type to string it explicitly checks classes like this:

if (doc instanceof Actor) .....

if (doc instanceof Item) .....

Perhaps there is a cleaner way of solving it, though.

Provide option to specify CSS class for styling.

Currently it is hard-coded to use "inlineDocument" as the name of the style, which is configured in the provided CSS file.

Provide a module option to specify a different CSS name, so that users can easily adapt their style to something else.

Add a style that has no colouring.

V12: enrichHTML is always async

Change the test for if (async) since that flag is no longer present in V12, the call is always async.

The functionality of this module might be redundant based on the new functionality of the @Embed tag - although that tag always embeds the entire article - and only works with Journal pages of type 'text' or 'image'.

Sentence detection fails if Foundry link appears in first sentence.

The first sentence detection doesn't work properly if there is a link in the first sentence, since it simply searches for the first "." and one of those might appear in the @UUID link within the linked document.