fanduel / jsonrpc2-elixir Goto Github PK

View Code? Open in Web Editor NEW

60.0 60.0 19.0 90 KB

JSON-RPC 2.0 for Elixir

License: Other

Elixir 100.00%

jsonrpc2-elixir's People

Contributors

Stargazers

Watchers

Forkers

ruby2elixir rosacris fbergero undr dkataskin untra ben-ic sashman wenyekui nkmanolovsumup msanterre whitered inomurko utrustdev ryanleecode gabrielgiordan skyllatech 25nyak garlic0x1

jsonrpc2-elixir's Issues

TCP doesn't works for large messages

Hello!

I'm trying to do connect between two Elixir's apps (tcp client -> tcp server)

Basically all works fine (!!!)

But when I try to send a large message (more than one tcp packet limit), I got multiple error:

[error] JSONRPC2.Clients.TCP.Protocol received response with null ID: {:error, {-32700, "Parse error", nil}}

(multiple times, on client side)

Looks like the client try to split a message and to send it in multiple requests.

It looks as:

# full message (cropped, it means a large image in the base64 parameter)
%{"base64" => "data:image/jpeg;base64,/9j/4AAQSkZJRgABAQEAYABgAAD/4REERXhpZgAATU0AKgAAAAgABAE7AAIAAAAcAAAISodpAAQAAAABAAAIZpydAAEAAAAeAAAQ3uocAAcAAAgMAAAAPgAAAAAc6gAA" <> ..., "caption" => ""}

# server receive splitted message as multiple messages and can't decode on each of them, so it do a response with error `Parse error` for each of them
# message 1
"{"params":[{"caption":"","base64":"data:image/jpeg;base64,/9j/4AAQSkZJRgABAQEAYABgAAD/4REERXhpZgAATU0AKgAAAAgABAE7AAAAA <> ..."
# message 2
"AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA <> ..."
# message 3
"AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA <> ..."
# last message:
"... <> ElFFFAgooooAKKKKACiiigAooooAKKKKACiiigAooooAKKKKAP/Z"},{"id":"1"}],"method":"create_image","jsonrpc":"2.0","id":0}"

Any ideas what I can do with it?

Here is deps for both apps:

     {:jsonrpc2, "~> 1.0"},
     {:shackle, "~> 0.5"},
     {:ranch, "~> 1.3.2"},

On application start on client app:

Client.TCP.start("localhost", 8001)

On application start on server app:

JSONRPC2.Servers.TCP.start_listener(Server.TCP, 8001)

All works fine for small messages.

Hex.pm documentation is broken

When trying to access documentation from Hex.pm (https://hexdocs.pm/jsonrpc2), page is not found and a message is shown telling you to report such issue.

Plug doesn't work with Content-Type: application/json

When using:

forward "/jsonrpc", JSONRPC2.Servers.HTTP.Plug, YourJSONRPC2HandlerModule

and sending via curl, a parse error occurs:

$ curl "localhost:4000/jsonrpc" -H "Content-Type: application/json" -d '{"jsonrpc":"2.0", "method": "hello", "id": 1}' 
{"jsonrpc":"2.0","id":null,"error":{"message":"Parse error","code":-32700}}%

Digging deeper, in JSONRPC2.Servers.HTTP.Plug, {:ok, req_body, conn} = Plug.Conn.read_body(conn) sets req_body to empty string. When inspecting the conn, the incoming body is definitely there and has already been parsed in the params field:

%Plug.Conn{adapter: {Plug.Adapters.Cowboy.Conn, :...}, assigns: %{},
...
 params: %{"id" => 1, "jsonrpc" => "2.0", "method" => "hello"},
...

So when forcing Content-Type to plain text, the plug works as expected:

$ curl "localhost:4000/jsonrpc" -H "Content-Type: plain/text" -d '{"jsonrpc":"2.0", "method": "hello", "id": 1}'
{"result":"Hello!","jsonrpc":"2.0","id":1}%

Is this intended and I might have something misconfigured?

Application level error handling

I have a Phoenix application using the JSONRPC2.Server.Handler and we use Sentry for error collection. I'd like to be able to integrate Sentry error reporting.

The library currently has nice detailed error logging but I'd like to implement an handle_error callback or similar to have JSONRPC2 handle the calls and response but allow the Rollbar, Sentry, other tool of choice be hooked in by the library user.

Thoughts on how this should look or if it's even in scope for the library, maybe this is doable now? I couldn't see an easy way without code change.

Debugging a HTTP call

Hi all,

I'm getting the correct content, but receiving:

{:error,
 {:invalid_response,
  %{
    "error" => nil,
    "id" => "0",
    "result" => [

which means the response code wasn't 200 (

jsonrpc2-elixir/lib/jsonrpc2/clients/http.ex

Line 35 in 9b6f5c6

{:ok, 200, _headers, body_ref} <- response,

)

Can you advise how to switch on debug to see the response? This client uses hackney, so I presume it's a hackney_opts

Thanks.

Request id is hardcoded in the http(s) client

When making a call via the http client no custom request id can be specified. The id is hardcoded to 0.

https://github.com/fanduel/jsonrpc2-elixir/blob/master/lib/jsonrpc2/clients/http.ex#L20

Problems with Content-Type: application/json in 1.1.0

Hi, I think I am getting a similar problem to #8?

I am not sure but I think this still doesn't work if I run JSONRPC2 in a Supervisor. Here's the way to reproduce:

mix.exs:

defmodule JsonTest.MixProject do
  use Mix.Project

  def project do
    [
      app: :json_test,
      version: "0.1.0",
      elixir: "~> 1.6",
      start_permanent: Mix.env() == :prod,
      deps: deps()
    ]
  end

  def application do
    [
      extra_applications: [:logger],
      mod: {JsonTest.Application, []}
    ]
  end

  defp deps do
    [
      {:jsonrpc2, "~> 1.1"}, {:poison, "~> 3.1"}, {:plug, "~> 1.3"}, {:cowboy, "~> 1.1"}
    ]
  end
end

application.ex:

defmodule JsonTest.Application do
  use Application

  def start(_type, _args) do
    children = [
      JSONRPC2.Servers.HTTP.child_spec(:http, JsonTest)
    ]
    opts = [strategy: :one_for_one, name: JsonTest.Supervisor]
    Supervisor.start_link(children, opts)
  end
end

json_test.ex:

defmodule JsonTest do
  use JSONRPC2.Server.Handler

  def handle_request(method, params) do
    :ok
  end
end

Then with JSONRPC2 1.1.0 as above I'm getting:

$ curl "localhost:4000/jsonrpc" -H "Content-Type: plain/text" -d '{"jsonrpc":"2.0", "method": "hello", "id": 1}'
{"result":"ok","jsonrpc":"2.0","id":1}
$ curl "localhost:4000/jsonrpc" -H "Content-Type: application/json" -d '{"jsonrpc":"2.0", "method": "hello", "id": 1}'
{"jsonrpc":"2.0","id":null,"error":{"message":"Invalid Request","code":-32600}}

If I downgrade to 1.0.3 then all is good:

Resolving Hex dependencies...
Dependency resolution completed:
Unchanged:
  cowboy 1.1.2
  cowlib 1.0.2
  mime 1.3.0
  plug 1.6.1
  poison 3.1.0
  ranch 1.3.2
Downgraded:
  jsonrpc2 1.1.0 => 1.0.3
* Updating jsonrpc2 (Hex package)
$ curl "localhost:4000/jsonrpc" -H "Content-Type: application/json" -d '{"jsonrpc":"2.0", "method": "hello", "id": 1}'
{"result":"ok","jsonrpc":"2.0","id":1}

fanduel / jsonrpc2-elixir Goto Github PK

jsonrpc2-elixir's People

Contributors

Stargazers

Watchers

Forkers

jsonrpc2-elixir's Issues

TCP doesn't works for large messages

Hex.pm documentation is broken

Plug doesn't work with Content-Type: application/json

Application level error handling

Debugging a HTTP call

Request id is hardcoded in the http(s) client

Problems with Content-Type: application/json in 1.1.0

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent