fahad-ha / fs-project-frontend

👋 Hi, I’m Fahad Ahmad

A self-taught full stack developer

Languages and Tools:

• 🌱 Currently working as a Fullstack Developer
• ✨ Portfolio: https://courageous-chebakia-f38c35.netlify.app
• 📫 How to reach me: [email protected]

fs-project-frontend's Issues

auth.js

Please remove dead aka commented out code.

This applies everywhere

Categories.js

There's a lot of repetitive code in this page that needs to be cleaned up. I understand you guys are relying on dummy data here but what can be done is have the categories setup as an array and then you can map on the elements of the array, adding it into the button, or card. That will ensure an easier transition to when you have the api integrated and functional

ErrorMsg.js

One way to improve readability for the following:

{" "} {error?.response?.data == "Bad Request" ? "Fields cannot be empty" : error?.response?.data?.message == "data and salt arguments required" ? "Fields cannot be empty" : error?.response?.data?.message || error?.response?.data || error?.message}

is having it setup this way:

{" "} {(() => { const responseData = error?.response?.status; const errorMessage = responseData?.message || error?.message;

if (responseData === "Bad Request" || errorMessage === "data and salt arguments required") {
  return "Fields cannot be empty";
} else {
  return responseData || errorMessage;
}

})()}

"data and salt arguments required" is not an appropriate message to show the user

images

It's better practice to have your images setup in a media folder within an assets folder like so: src>assets>media>Dev-image.jpg