faforever / faftools

Shared python code between lobby/server

FAForever Shared Library

This is a utility library for the various things we do at lobby and server

License

Please see the license.txt file

faftools's Issues

Maps may break

Generate Map Upload may break the map

• it get the name from scenario.lua map key and replace it with a new one case sensitive. (

  faftools/faf/tools/fa/maps.py

  Line 366 in 982073d

  def extract_map_name(lua_data):

  )
• Replace maybe miss some expressions (

  faftools/faf/tools/fa/maps.py

  Line 276 in 982073d

  # This is a bit risky (possible false positives), that's why there is a safety net above

  )

https://faforever.slack.com/archives/general/p1485308092008963

Solution:

• still rename map folder to <mapname>.v<0-4version>
• replace the maps\<oldname> with the new maps\<mapname>.v<0-4version>
• don't rename other lua files, because it errorprone to replace references

Discuss Multi Cardinality Schema

@Cheyans
Also we still haven't discussed how you want a multi cardinality schema represented, e.g. https://github.com/FAForever/faftools/blob/feat/clan/faf/api/game_stats_schema.py

seeing how dragonfire has also ran into this issue, we should probably discuss a good solution

@IDragonfire Problem
API Clan/<id> should provide

1. clan details
2. List of clan members

Explicit versions in requirements.txt

Without specifying versions, we're gambling and builds are not reliably reproducible.
We should explicitly define the version of each dependency.

faftools has python3-only code

Just making a note here, everything seems to work anyway, but installing faftools in Miniconda's Python 2.7.13 causes this error message:

Extracting faftools-0.1-py2.7.egg to c:\users\luke\miniconda2\envs\fafclient\lib\site-packages
  File "c:\users\luke\miniconda2\envs\fafclient\lib\site-packages\faftools-0.1-py2.7.egg\faf\api\async_client\async_client.py", line 10
    async def get(self, url, **kwargs):
            ^
SyntaxError: invalid syntax

As long as everything works anyway nothing needs to be done I guess.

Error while calling ApiClient.get()

minimal working example :
import faf.api.client
api = faf.api.client.ApiClient()
api.get("/maps")

The log complains about a list not having a get method here: https://github.com/FAForever/faftools/blob/develop/faf/api/client/client_base.py#L37
when downloading http://api.faforever.com/maps manually you can see that first would be a list in this case ( similar stuff happens for .../mods)

Blueprint tools

As a spinoff from the discussion in this issue, we need a blueprint toolkit (here in faftools, or a new repo) that does the following:

• Parses unit blueprints
• Validates a set of blueprints against a specific ruleset
• Optionally modifies blueprints and persists the changes

Modifying the blueprints (Either using a comment or an actual value) for use by this toolkit would be acceptable in my mind.

mod validation is overly strict

When uploading a mod via the python-api with url = "" in the mod_info.lua, this exception is thrown:

  File "/code/api/mods.py", line 85, in mods_upload
    process_uploaded_mod(temp_mod_path)
  File "/code/api/mods.py", line 206, in process_uploaded_mod
    mod_info = parse_mod_info(temp_mod_path)
  File "/usr/local/lib/python3.5/site-packages/faf/tools/fa/mods.py", line 52, in parse_mod_info
    raise ValueError(errors)
ValueError: {'url': ['Not a valid URL.']}

That is probably too strict.

Differentiate connection messages in game lobby

All those "Connecting to XYZ established" and similar messages make it really hard to find actual chat messages in the in-game lobby chat.

Maybe we could either colorize these messages so that they are easily distinguishable, or we could separate those messages from the chat window.

Map preview: Don't render all blank markers as ACU markers

Only the ones with prefix ARMY_