fack2 / hebronrest-updated

Hebron Rest:

Description:

A website that shows the user several types of cuisines to choose from. When the user clicks on one of them, it shows a list of restaurants that serve that type of cuisine. It also allows you to add a resturant if you want, with a list of details about it using a form.

User journey:

• As a user I'm able to choose a cuisine.
• As a user I'm able to see a list of restaurants and some details about them.
• As a user I'm able to add a new restaurant by filling a form only if I'm logged into the website.
• As a user I sign up to the website.

Wireframe:

• Home page:

• Login and sign up:

File Structure:

• public:

  • images:
    • 1.png
    • 2.png
    • 3.png
    • AbuMazin.png
    • TabonAlreef.png
    • KFC.png
    • RozaChrunchy.png
    • Q-Cany.png
    • Segafredo.png
    • logo.png
  • index.html
  • style.css
  • index.js

• src:

  • database:
    • test:
      • databaseTest.js
    • db_build.js
    • db_build.sql
    • db_connection.js
  • queries:
    • getData.js
    • postData.js
  • server:
    • test:
      • test.js
    • handler.js
    • router.js
    • server.js

• .gitignore
• .travis.yml
• package.json
• README.md

Schema:

Website flow:

Team:

• Rand
• Rawan
• Duaa
• Sahar

hebronrest-updated's Issues

the user must be unique

you use the user name to login for multiple users

validation

there is no any validation like email

Asynch function

Database queries are asynch function so you have to make sure the data has been added into the database before setting the header and check the errors as well

HebronRest-Updated/src/server/handler.js

Lines 108 to 110 in e2fce6b

	postData(result, (err, data) => {});
	res.writeHead(302, { Location: '/' });
	res.end();

Database instructions

Add the instructions of building a local database on the README. describe for the users how they can run the code locally

Create database

We're creating a new local database and updating the one we stole from the previous restaurant project

Creating login endpoint

Delete merged branches !!!

remove console.log()

HebronRest-Updated/src/server/handler.js

Line 95 in e2fce6b

console.log(

Check the cookies

Why did you pass a file as a parameter since you can check the cookies as a first step and handle the page depend on the result like:

if(req.headers.cookie === undefined){
// handle the login/signup page
}else{
// get the cookies values and handle the home page
}

HebronRest-Updated/src/server/handler.js

Lines 13 to 14 in e2fce6b

	let filePath = path.join(__dirname, '..', '..', 'public', `${page}.html`);
	if (page === 'profile') {

Hide the secret key

The secret should be in .env file

HebronRest-Updated/src/server/handler.js

Line 16 in e2fce6b

jwt.verify(comingToken, '123456',(err,jwt)=>{

Delete unnecessary code

Delete all the console logs from your code

HebronRest-Updated/src/server/handler.js

Lines 95 to 107 in e2fce6b

	console.log(
	'cuisine',
	result.cuisine,
	'name',
	result.res_name,
	'location',
	result.location,
	'phone',
	result.phone,
	'delivery',
	result.delivery,
	'phone'
	);

Some Modules are missing!

These modules do not exist in your package json file bycrept, jsonwebtoken query-string and cookie

crashed when login with new user name

if the user name does not exist in data base server crashes

null obj in dom

in login page no button search and id then will be return null and you can't addEventListener for null

you can create new file dom

i can login for any password

Adding Instructions to run your project in Readme !!!

after registering the restaurant you should sent feedback message registration is success !!!

Creating sign up endpoint