fack2 / football_teams

Football_teams ⚽

About :

our website allows user to search about football, teams in specific country (Spain , England), displays the teams in this country, and some details about it.

User journey:

As a user, I will be able to:

• enter a country name
• click on search button and see the all teams in this country.
• click on team name and see more details about them.

Sketch :

Schema:

File structure

• Public folder:
  • index.html
  • style.css
  • script.js
• Src folder:
  • server.js
  • router.js
  • handler.js
  • database folder:
    • db_build.js
    • db_build.sql
    • db_connection.js
  • queries folder:
    • getData.js
    • postUser.js
• config.env

Flow

Team members:

• Duaa
• Saja
• Munir
• Someya

football_teams's Issues

create design html and css

User may type country team in small letters

ID I type spain in the input, I'll get nothing.

You can fix that by adding ILIKE instead of = in the query of selecting teams.

search result

when you search for one thing and then search for another, both results show up on the screen

you can use variables in SQL so you dont need to check what the country is

Football_teams/src/queries/getData.js

Lines 4 to 7 in b493e53

	if (country === "Spain") {
	dbConnection.query(
	"select teams.logo , teams.description,teams.team_name, countries.country_name from countries inner join teams on teams.id_countries = countries.id_countries where countries.country_name='Spain'",
	(err, res) => {

so instead of this, you can do :

dbConnection.query(
      "select teams.logo , teams.description,teams.team_name, countries.country_name from countries inner join teams on teams.id_countries = countries.id_countries where countries.country_name=$1", [country]
      (err, res) => { ...

create flow

why have you got two assets folders?

create database

Required the querystring and didn't use it

Football_teams/src/handler.js

Line 4 in b493e53

const queryString = require("querystring");

When click search button multiple times, the previous teams is not gone

You can fix this issue by empty the list after clicking the button ( before appending children).

Need to add some texts above the search box

To make the client understand what is this website doing, and what should he type in the search-box.

no tests!

I want you all to pay extra attention in the presentations to how other groups wrote their tests,
I will be asking you questions on this so be warned !

create file structure in editor

Loved the sketch

Selecting the country

Football_teams/src/queries/getData.js

Lines 4 to 15 in b493e53

	if (country === "Spain") {
	dbConnection.query(
	"select teams.logo , teams.description,teams.team_name, countries.country_name from countries inner join teams on teams.id_countries = countries.id_countries where countries.country_name='Spain'",
	(err, res) => {
	if (err) {
	return cb(err);
	}
	console.log("res", res);
	cb(null, res.rows);
	}
	);
	} else if (country === "England") {

You're specifying the country using an if statement, you should use a query insteaed

css problem

when you show the info for a football club, it overlaps with the section under it

Add how to run project section in readme file

There are no instructions in the ReadMe file to clarify how to run te project on my PC. Also, need to clarify what env variables need to be set.

Remove unused variables

Football_teams/src/handler.js

Lines 3 to 5 in b493e53

	const url = require("url");
	const queryString = require("querystring");
	const request = require("request");

These variables are unused in this file. I know you may need it later, but you can require it if you need it. So, you can get rid of it now!

a good tool for drawing schemas...

https://www.draw.io/

if you go to the panel on the left and click on 'entity relation', you can make diagrams like this which is the standard way of visualising schemas.

create file structure

is it on heroku?

couldnt see any link.
if its not on heroku then this is what you should focus on this morning !

Create dom.js

Browser shouldn't have an errors

Remove errors from the browser console, this can be done by adding a favicon to the files, this will add a small nice icon to your site app.

create database schema

create user story

Name of foreign key

Football_teams/src/database/db_build.sql

Line 13 in b493e53

FOREIGN KEY (id_countries) REFERENCES countries(id_countries),

You are free to use any name for the foreign key, but preferred and the preferred name and the name that makes sense is to name is country_id.

Because each team related to one country. So, it doesn't make sense to add country_id.

Delete unused modules

Football_teams/package.json

Line 32 in b493e53

"request": "^2.88.0",

Better to remove this unused module. Your server (until now) is not sending any request to another server. so you can remove this module from your package.json

some of devDependencies are in Dependencies

Football_teams/package.json

Lines 28 to 34 in b493e53

	"dependencies": {
	"env2": "^2.2.2",
	"eslint": "^6.1.0",
	"pg": "^7.11.0",
	"request": "^2.88.0",
	"supertest": "^4.0.2"
	}

Some of the devDependencies are in dependencies. You don't need these modules in the production-mode:

{
    "eslint": "^6.1.0",
    "supertest": "^4.0.2"
}

Heroku link dosen't work

Travis file is empty

commits should be more even...

these should be even, Someya and Saja have the fewest commits. This suggests you did the least typing, it is the whole teams responsibilty to ensure that these are even

no need to wrap this in a function because it never gets called anywhere else

Football_teams/src/server.js

Lines 6 to 13 in b493e53

	const startServer = () => {
	server.listen(port, () => {
	console.log(`Magic happens on port ${port}`);
	});
	};
	startServer();