Rebase to F4.0.4.29a? about tac_plus

[cooperlees]

I had the same issue when overhauling our tacacs infra ~2 years ago (e.g. To do v6) and since this is all internal only we've stuck with the devil we know rather than other forks etc.

One day it would be nice to run a more modern code base + language etc. but vendors cater for this daemon and I can't justify the time as this works, even with our load (I don't run very many instances of this at all in prod)

[cooperlees]

Where is the official repo these days for tac_plus?

[pprindeville]

Where is the official repo these days for tac_plus?

There isn't one. Heasley just releases tarballs, so there's no visibility into what patches have been accepted, what changes are made, etc.

There is, however, yet another fork. Mine. Sigh.

https://github.com/pprindeville/tac_plus/

One day it would be nice to run a more modern code base + language etc. but vendors cater for this daemon and I can't justify the time as this works, even with our load (I don't run very many instances of this at all in prod)

I'm open to accepting other people's fixes. I do have one caveat: I don't like whitespace-only changes so hunks containing things like changing indent or tabs-to-spaces or trimming blanks for the end of lines will be rejected.

[pprindeville]

Where is the official repo these days for tac_plus?

There isn't one. Heasley just releases tarballs, so there's no visibility into what patches have been accepted, what changes are made, etc.

There is, however, yet another fork. Mine. Sigh.

https://github.com/pprindeville/tac_plus/

One day it would be nice to run a more modern code base + language etc. but vendors cater for this daemon and I can't justify the time as this works, even with our load (I don't run very many instances of this at all in prod)

I'm open to accepting other people's fixes. I do have one caveat: I don't like whitespace-only changes so hunks containing things like changing indent or tabs-to-spaces or trimming blanks for the end of lines will be rejected.

[cooperlees]

So how would you want to go about doing this?

It seems like you want me to give our patches to you ... The commits are all here in the open on Github - Feel free to take them and apply to your newer fork. I can test the code on a test server or two here @ Facebook once we have a building version.

[pprindeville]

So how would you want to go about doing this?

I currently don't have a lot of IPv6 infrastructure to test on, so I was hoping you could forward-port the changes, test them, and send me patches (or a PR) which I could then merge.

Thanks

[cooperlees]

I do have the time or need to port my changes to your updated version sir. If you need them you're going to have to pull them from this repo and apply. VPS's with IPv6 are so cheap these days, you could write a tester or get some random network devices to talk to said VPS. Sorry I can't help anymore, other priorities at the moment.