Segfault in tac_plus about tac_plus

[cooperlees]

I believe the succeed on fail is a client decision (I could be wrong). I would double check to see with the child segfault if any message gets sent back to your router.

I don't think you're doing anything wrong and just some love between PAM + this old codebase probably needs some debugging like you've found. Maybe asking in some PAM github repo, forum etc. might be the next best step, as, I too, am no PAM guru.

[richard-allen]

Looking at the gdb output, I just had a terrifying thought, which I promptly tested and yes it's true. It matters not what I type into the first factor prompt, it succeeds. ALso, it matters not what I type into the second factor prompt. Still succeeds :)
I have to mess up the username field before logins fail

[cooperlees]

Well this is either a bug in PAM / Tacacs interaction with PAM or your PAM config from what I see. I've changed teams at Facebook and don't have time to debug this, nor do I have the ability to create a repro of your setup (We don't use dual factor on TACACS+ devices, we do elsewhere to get into production). So if you can fix this and show how you've tested it I am sure we will happily accept a PR.

[richard-allen]

Ok... Do you think anyone at facebook would be interested in diagnosing this with me? I could provide a clone of this VM complete with all the setup in no time if needed and give access to the system to work this out and a test router to trigger the bug.
PS: can you see anything abvious errors in the PAM config? It's just basicly calling system-auth for most things and that should be pretty well tested.

[cooperlees]

We won't have time to help here sir. If you work it out, PRs will be welcome.

[cooperlees]

Can't help on custom LDAP + PAM issues we can not reproduce in our environment.