[Compiler Bug]: false positive when using hooks in a nested component about react

[josephsavona]

Thanks for posting. The compiler does not yet support nested component definitions (components defined within another component). This is something we may add support for in the future depending on demand.

In the meantime though, we should provide a better diagnostic (“nested components not yet supported”) rather than throw a hook error.

[josephsavona]

@RafaelJohn9 we're open to PRs to improve the warning!

[RafaelJohn9]

@josephsavona

In the meantime though, we should provide a better diagnostic (“nested components not yet supported”) rather than throw a hook error.

Can I work on this, or it was just an afterthought

[RafaelJohn9]

@josephsavona, I will be working on it.

[last-Programmer]

we are also getting this kind of error in our application when using react-compiler. this is not the eslint warnings. happens actually while running the application

@NMinhNguyen Is this only eslint warning or error happens while running the application? thanks

[josephsavona]

@last-Programmer the error here is specifically reported by the ESLint plugin. It can be reported by the Babel plugin, but only if you’ve changed the plugin settings, which we don’t recommend.

So most likely you’re seeing a different error, can you create a separate issue please w info on how to reproduce? Thanks!

[RafaelJohn9]

hey @josephsavona sorry, I did not notice earlier my PR has merge conflicts, I'll close it and make another PR.
I do have a question, am I to add tests to the changes that I have made, and if I am to, what about the previous tests that were written?
Thank you in advance.

[RafaelJohn9]

@josephsavona