Comments (4)
You are creating a new, lazy component within render. The component type is therefore changing on every render. Then React has to re-render when the lazy resolves but encounters a new lazy component since you called lazy()
again. This is expected behavior.
Do you still enter an infinite loop if you move the component creation outside of render?
+const TargetComponent = lazy(...)
function Case() {
- const TargetComponent = lazy(...)
return <TargetComponent />
}
I'd recommend splitting these up into different repros. It's hard to follow how you use the repro and what you're actually reproducing.
from react.
Do you still enter an infinite loop if you move the component creation outside of render?
I was able to prevent infinite loop for 'Case 1'. But unfortunately, 'Case 3' is still suffering from infinite loop.
And, moving the React.lazy
outside of render has limits. Due to the inability to utilize component props, 'React.lazy' can only be used statically.
for example, I have an component that takes file names as props and renders dynamically based on them. According to the proposed solution, this code can no longer be used.
from react.
And, moving the React.lazy outside of render has limits. Due to the inability to utilize component props, 'React.lazy' can only be used statically.
You need to implement a client cache then. React doesn't have that capabiltiy at the moment. Unconditionally creating React.lazy
during render is not supported. Just like you couldn't create a new Promise during render and pass it to use
.
It's probably better to use some form of codegen to create the icons anyway so that all available icons are known statically.
I was able to prevent infinite loop for 'Case 1'. But unfortunately, 'Case 3' is still suffering from infinite loop.
Do you have a repro just for that case with the React.lazy
created outside of render?
from react.
Thank you for replying.
It's probably better to use some form of codegen to create the icons anyway so that all available icons are known statically.
I thought the same thing, and I checked that lots of icon libraries are supporting icons in the form of codegen which is statically generated. (like lucide)
Do you have a repro just for that case with the React.lazy created outside of render?
I was trying to repro the infinite rerender on my local machine, but it doesn't make any infinite loop when React.lazy created outside of render.
I think it's environment issue related with Codesandbox which is not that import at this moment.
Thank you for supporting, this conversation helped me a lot understanding react deeper.
from react.
Related Issues (20)
- ..
- [DevTools Bug]: 5.2.0 is not available for Firefox HOT 2
- [DevTools Bug] getCommitTree(): Invalid commit "1" for root "445". There are only "1" commits.
- [eslint-plugin-react-hooks] Missing type declarations HOT 2
- [React 19]
- Bug: useEffect is triggered even if the array as dependency variable wasn't changed. HOT 4
- [DevTools Bug]: React Devtools not working neither on vite or cra project HOT 5
- ..
- Bug: Error Recovery Mechanism Overwriting Initial Rendering Errors in Concurrent Mode HOT 1
- Bug: Empty `style={}` object values cause hydration warnings in React 18.3.1 - Includes solution
- [React 19] Cannot assign to readonly property HOT 8
- Unexpected Initial State Jump in 'useEffect" with 'setTimeout' and State Dependencies HOT 3
- React[19] Module '"react"' has no exported member 'useActionState'. HOT 2
- Bug: effect runs with stale state values outside of Concurrent React HOT 1
- Feature Request: ESLint hooks rule for accessing previous state when deriving new state
- Bug: Weird Behavior of useCallback() hook When Variables or States Are defined before and after the Callback (ES5) HOT 5
- Bug: div: `ref` is not a prop HOT 2
- Bug: useFormStatus pending state is reset when component state is updated HOT 3
- [React 19] TEST HOT 1
- `FALLBACK_THROTTLE_MS` slows tests down significantly - could it be configurable? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react.