Comments (6)
Thank you for the comprehensive repro.
I reduced it a bit more and also added two potential workarounds that I highlighted in comments as "Alternate A" and "Alternate B" as well as one with (in my opinion) degraded UX in "Alternate C": https://stackblitz.com/edit/react-9vvm42?file=src%2FApp.js
First two clicks create just one pending update. Everything works fine.
Last click happens while the action from the prior click is still pending, creating this intermediate state where an item is both in the optimistic and non-optimistic slice.
Screencast.from.18.03.2024.11.01.08.webm
I also added a test that repros the original issue: #28575
However, I'll double check with the team if this shouldn't have "just worked" as you authored it. If either of the workarounds are required, we should definitely document it. Especially since it's not quite clear to me how this would work with primitives e.g. incrementing an optimistic click counter.
from react.
FYI, This could be reproed in the official demo
optimistic.mov
from react.
@eps1lon Your "Alternate A" solution is pretty clear and works great.
However, I have a questions about "Alternate B" solution.
Why optimistic update function is called 3 times every time optimistic state is updated?
![image](https://private-user-images.githubusercontent.com/9947582/316099612-3da16c1f-4d08-41bd-be52-f4f153bfb7b1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTYyNDYwNDQsIm5iZiI6MTcxNjI0NTc0NCwicGF0aCI6Ii85OTQ3NTgyLzMxNjA5OTYxMi0zZGExNmMxZi00ZDA4LTQxYmQtYmU1Mi1mNGYxNTNiZmI3YjEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDUyMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA1MjBUMjI1NTQ0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YTVhYTFjNTQ0YTYyZGJhOWQwNWY5MTFjMDg1MWEzMTY3NzA5YmU0N2EzY2RhNDExMTE0ZjY2OGM5YTQyNzkxMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.FXYXzjc42pM2vr-61m38D8BtiFXJVk1pfjIcFdVpAjo)
And how this solution work at all, I mean, how item can be inside non-optimistic state earlier optimistic version if we append it to optimistic version first? 🤔
from react.
Why optimistic update function is called 3 times every time optimistic state is updated?
When an action completes, we rebase the optimistic updates (i.e. replay) on top of the passthrough value (the non-optimistic state). That's why you see multile calls.
from react.
@eps1lon thank you for the explanation.
And how this solution work at all, I mean, how item can be inside non-optimistic state earlier optimistic version if we append it to optimistic version first? 🤔
Could you throw the light on the question above?
from react.
Because we added it to the non-optimistic slice but it's still in the optimistic slice because one action is still pending.
from react.
Related Issues (20)
- React compiler requires that expressions referenced in handler code are always resolvable HOT 1
- 2024 谷歌蜘蛛池出租:谷歌蜘蛛池出租厂家
- `react-compiler-healthcheck` prints "StrictMode usage not found." in Next.js project with `reactStrictMode: true` in `next.config.js`
- [React 19] react compiler warns about mutating ref in specific case
- [React 19] react-compiler warns when mutating globals inside useCallback
- [React 19] `transformOrigin` is Missing From Type `SVGAttributes`.
- React compiler healthcheck (and ESLint plugin) ignores all files if a babel.config.js file is present HOT 8
- react-compiler transformed conditional useCallback call incorrectly HOT 8
- Bug: Cannot run compiler playground locally HOT 2
- [Compiler Bug]: value read during render does not update when using `react-hook-form` `.watch` API HOT 4
- Bug: Truffle firefox extension causes a uncaught runtime exception on fresh react app HOT 1
- "This page doesn’t appear to be using React." all the time! HOT 2
- [Compiler Bug]: Compiler disagrees with `exhaustive-deps` linter on whether `React.Ref<T>.current` must be in a deps array HOT 1
- [Compiler Bug]: Compiler doesn't bail out when reading or writing `ref.current` during a render HOT 3
- [DevTools Bug]: Version 5.2 shows incorrect source for all the components HOT 2
- [Compiler Bug]: false positive when using hooks in a nested component HOT 8
- Bug: Displayed content is not handled properly. HOT 3
- [Compiler Bug]: don't uses dependecies of useMemo HOT 1
- [Compiler Bug]: Values used as indexes are not memoized HOT 4
- [Compiler Bug]: Issue with React Hook Form library HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react.